Closed
Bug 1366550
Opened 8 years ago
Closed 8 years ago
Consistently remove the dropdown arrow from all type=menu toolbarbuttons in the navigation toolbar
Categories
(Firefox :: Theme, enhancement, P1)
Firefox
Theme
Tracking
()
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: dao, Assigned: johannh)
References
Details
(Whiteboard: [photon-visual][p1])
Attachments
(1 file)
We currently do this only for known built-in buttons. It makes sense to assume that we'll want the same if we add another menu button, and to treat add-on buttons the same way.
Johann, want to take this? It will make bug 1352358 easier.
Flags: needinfo?(jhofmann)
Updated•8 years ago
|
Flags: qe-verify?
Priority: -- → P2
Assignee | ||
Comment 1•8 years ago
|
||
Sure.
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Flags: needinfo?(jhofmann)
Comment hidden (mozreview-request) |
Reporter | ||
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8870024 [details]
Bug 1366550 - Hide the dropdown arrow of type=menu and type=panel buttons in the navbar.
https://reviewboard.mozilla.org/r/141546/#review145132
::: browser/themes/shared/toolbarbuttons.inc.css:116
(Diff revision 1)
> -moz-appearance: none;
> padding: 0;
> margin: 0;
> }
>
> -#nav-bar .toolbarbutton-1:not([type=menu-button]),
> +#nav-bar .toolbarbutton-1,
Need to keep :not([type=menu-button]) here. type=menu-button is different from type=menu.
::: browser/themes/shared/toolbarbuttons.inc.css:194
(Diff revision 1)
> #nav-bar .toolbarbutton-1 > .toolbarbutton-menubutton-button > .toolbarbutton-icon {
> border-inline-end-style: none;
> }
>
> -#nav-bar .toolbarbutton-1[type=panel] > .toolbarbutton-icon,
> -#nav-bar .toolbarbutton-1[type=panel] > .toolbarbutton-badge-stack,
> +#nav-bar .toolbarbutton-1[type=menu] > .toolbarbutton-menu-dropmarker,
> +#nav-bar .toolbarbutton-1[type=panel] > .toolbarbutton-menu-dropmarker {
#nav-bar .toolbarbutton-1 > .toolbarbutton-menu-dropmarker
Attachment #8870024 -
Flags: review?(dao+bmo) → review+
Comment hidden (mozreview-request) |
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0e00320b59a
Hide the dropdown arrow of type=menu and type=panel buttons in the navbar. r=dao
Updated•8 years ago
|
Iteration: --- → 55.6 - May 29
Priority: P2 → P1
Comment 6•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•7 years ago
|
Flags: qe-verify? → qe-verify-
Comment 7•7 years ago
|
||
Out of curiosity, was there a reason to do this only on the nav-bar? What happens if users customize buttons to the tabstrip or bookmarks toolbar?
Flags: needinfo?(dao+bmo)
Reporter | ||
Comment 8•7 years ago
|
||
(In reply to :Gijs from comment #7)
> Out of curiosity, was there a reason to do this only on the nav-bar? What
> happens if users customize buttons to the tabstrip or bookmarks toolbar?
We only do it where we apply the toolbarbutton-1 styling (otherwise we fall back to native). If/when we make that include the bookmarks toolbar, we should hide the dropmarker there too. The tabs toolbar is included as of <https://hg.mozilla.org/mozilla-central/rev/be624d4f3f132c032429381517a2e736563dac38>.
Flags: needinfo?(dao+bmo)
You need to log in
before you can comment on or make changes to this bug.
Description
•