Comment on attachment 8876076 [details] Bug 1366662 - Add build config for Photon with default enabled on gradle build, https://reviewboard.mozilla.org/r/147508/#review151942 This adds the flag, but doesn't actually _use_ the `photon` skin flavor dimension in the Gradle build. That is, this is still using the `officialAustralis` Gradle configuration and not the `officialPhoton` Gradle configuration. You'll want to make the following conditional on `MOZ_ANDROID_PHOTON`: http://searchfox.org/mozilla-central/source/mobile/android/base/Makefile.in#237 http://searchfox.org/mozilla-central/source/mobile/android/base/Makefile.in#241 and also http://searchfox.org/mozilla-central/source/mobile/android/base/Makefile.in#483 http://searchfox.org/mozilla-central/source/toolkit/mozapps/installer/upload-files-APK.mk#35 I don't think you need to do this -- skins will be rare -- but we could also make this `MOZ_ANDROID_SKIN_FLAVOR_DIMENSION`, have that be `photon` or `australis`, and substitute it (with the right capitalization) as necessary. No need to actually do this, but be aware that it's a possiblity, if the conditional approach is hard to do. ::: mobile/android/config/mozconfigs/android-api-15-gradle/nightly:5 (Diff revision 1) > . "$topsrcdir/mobile/android/config/mozconfigs/common" > > . "$topsrcdir/mobile/android/config/mozconfigs/android-api-15/nightly" > > +ac_add_options --with-mobile-photon Sebastian: Max wants to get a build with Photon enabled in automation; the Gradle build is there for the taking, so I support doing this. ::: mobile/android/moz.configure:71 (Diff revision 1) > > project_flag('MOZ_ANDROID_DOWNLOAD_CONTENT_SERVICE', > help='Background service for downloading additional content at runtime', > default=True) > > +option('--with-mobile-photon', Let's go with `--enable-photon`, since these options are already `mobile/android` specific. ::: mobile/android/moz.configure:72 (Diff revision 1) > project_flag('MOZ_ANDROID_DOWNLOAD_CONTENT_SERVICE', > help='Background service for downloading additional content at runtime', > default=True) > > +option('--with-mobile-photon', > + help='Build with refreshing Photon UI on mobile', Maybe just 'Enable Photon UI'? The "on mobile" is implied already, and it won't be refreshing (or refreshed) for very long -- it'll be default.

Comment on attachment 8876076 [details] Bug 1366662 - Add build config for Photon with default enabled on gradle build, Note I'll be on PTO starting tomorrow until the All-Hands. But go ahead and land as soon as :nalexander gives r+. > Sebastian: Max wants to get a build with Photon enabled in automation; the Gradle build is there for the taking, so I support doing this. Yeah, sounds like a good plan. Let's do this.