Closed
Bug 1366770
Opened 8 years ago
Closed 7 years ago
Custom Tab: Toolbar still displayed if a video is fullscreen
Categories
(Firefox for Android Graveyard :: General, defect, P2)
Tracking
(fennec+, firefox55 unaffected, firefox56 disabled, firefox57 verified)
VERIFIED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| fennec | + | --- |
| firefox55 | --- | unaffected |
| firefox56 | --- | disabled |
| firefox57 | --- | verified |
People
(Reporter: sflorean, Assigned: droeh)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
Environment:
Device: Huawei Honor (Android 5.1.1);
Build: Nightly 55.0a1 (2017-05-22);
Steps to reproduce:
1. Open https://www.w3schools.com/html/html5_video.asp in custom tab;
2. Tap full screen button and play the video.
Expected result:
The video enters full-screen and no visible issues are displayed.
Actual result:
The video enters full screen but the toolbar is still displayed.
|
Reporter | |
Updated•8 years ago
|
status-firefox55:
--- → affected
|
||
Comment 1•8 years ago
|
||
note: I see there is a callback for Fullscreen in GeckoView[1]. Maybe we can use this callback once CusttomTabs involves GeckoView.
Jim, is my assumption for the callback correct? or the callback is for another purpose? Thanks!
[1] https://dxr.mozilla.org/mozilla-central/rev/f9ca97a334296facd2e0ea5582e7f12d0fe70fe4/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoView.java#1128
Flags: needinfo?(nchen)
|
||
Comment 2•8 years ago
|
||
Yes, `onFullScreen` is called when Gecko is requesting full screen mode, and the app should implement `onFullScreen` to make the whole activity go full screen.
Flags: needinfo?(nchen)
|
||
Comment 3•7 years ago
|
||
per the discussion with Joe and Julian, this is P2 bug we could fix in the later phase.
Priority: -- → P2
|
|
Reporter | |
Updated•7 years ago
|
Blocks: customtabs_geckoview
tracking-fennec: --- → ?
status-firefox55:
affected → ---
status-firefox57:
--- → affected
|
Assignee | |
Comment 4•7 years ago
|
||
This is a simple fix.
Assignee: nobody → droeh
Attachment #8895370 -
Flags: review?(snorp)
Comment on attachment 8895370 [details] [diff] [review]
Implement onFullScreen for custom tabs
Review of attachment 8895370 [details] [diff] [review]:
-----------------------------------------------------------------
I think you should use ActivityUtils.setFullScreen(), as that has some additional considerations for various OS versions
Attachment #8895370 -
Flags: review?(snorp) → review-
|
|
Assignee | |
Comment 6•7 years ago
|
||
Ah, good point.
Attachment #8895370 -
Attachment is obsolete: true
Attachment #8895405 -
Flags: review?(snorp)
Attachment #8895405 -
Flags: review?(snorp) → review+
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/66d4f2c88db7
Implement ContentListener.onFullScreen() for custom tabs. r=snorp
tracking-fennec: ? → +
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
|
||
Updated•7 years ago
|
status-firefox55:
--- → unaffected
status-firefox56:
--- → disabled
|
|
Reporter | |
Comment 9•7 years ago
|
||
Verified as fixed in build 57.0a1 2017-08-28;
Device: Asus ZenPad 8 (Android 6.0.1).
When the video enters full screen, the toolbar is not displayed.
Status: RESOLVED → VERIFIED
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•