Closed Bug 1366787 Opened 8 years ago Closed 7 years ago

Small lag when autocompleting

Categories

(Firefox :: Address Bar, defect, P3)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: julienw, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [fxsearch][fxperf:p3])

Using a recnet nightly (20170517100341) I have a small lag after typing the first letter in the location bar. I recorded a profile: https://perf-html.io/public/446f4bf7457da11c84841106f0adc9af8193823b/calltree/?range=4.4106_6.9525&thread=0
most of the time is spent in _handleOverUnderflow, most part from _handleOverflow, part from _removeMaxWidths. The former is tracked, for the latter we could maybe store whether we set maxWidths before even trying to remove them.
Depends on: 1356532
Whiteboard: [photon-performance][fxsearch]
Whiteboard: [photon-performance][fxsearch] → [photon-performance][fxsearch] [triage]
Flags: qe-verify?
Priority: -- → P3
Whiteboard: [photon-performance][fxsearch] [triage] → [reserve-photon-performance][fxsearch] [triage]
Whiteboard: [reserve-photon-performance][fxsearch] [triage] → [reserve-photon-performance][fxsearch]
Flags: qe-verify? → qe-verify+
QA Contact: adrian.florinescu
Priority: P3 → P4
Priority: P4 → P3
Whiteboard: [reserve-photon-performance][fxsearch] → [reserve-photon-performance][fxsearch] [fxperf]
Whiteboard: [reserve-photon-performance][fxsearch] [fxperf] → [reserve-photon-performance][fxsearch] [fxperf:p3]
Whiteboard: [reserve-photon-performance][fxsearch] [fxperf:p3] → [fxsearch][fxperf:p3]
I don't know if I got used to this or if it just disappeared, but I think I don't see this anymore. Should we close it or do you still want to track some of the work outlined in comment 1?
Since we are tracking bug 1356532, and I already fixed the _removeMaxWidths part, I guess this open bug has no benefits. Thanks.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.