Closed Bug 1366969 Opened 7 years ago Closed 5 years ago

Failure in XMLHttpRequest/send-authentication-basic.htm

Categories

(Core :: DOM: Core & HTML, defect, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: shawnjohnjr, Assigned: twisniewski)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1366969 - fix some WPTs to not re-use the same 'valid once per session' auth landing, which incorrectly causes test-failures. r?annevk
(deleted), text/x-phabricator-request
Details 
XMLHttpRequest: send() - "Basic" authenticated requests with user name and password passed to open()	

assert_equals: expected "DID" but got "DID-NOT"
Assignee: nobody → shuang
I think the reason of failure is relate to the previous test case had already did authentication.



[task 2017-05-31T09:18:47.341026Z] 09:18:47     INFO - TEST-START | /XMLHttpRequest/send-authentication-basic-cors.htm
[task 2017-05-31T09:18:47.412761Z] 09:18:47     INFO - PID 1531 | 1496222327409	Marionette	DEBUG	loaded listener.js
[task 2017-05-31T09:18:47.555653Z] 09:18:47     INFO - .
[task 2017-05-31T09:18:47.555992Z] 09:18:47     INFO - TEST-OK | /XMLHttpRequest/send-authentication-basic-cors.htm | took 216ms
[task 2017-05-31T09:18:47.556454Z] 09:18:47     INFO - TEST-START | /XMLHttpRequest/send-authentication-basic-repeat-no-args.htm
[task 2017-05-31T09:18:47.635050Z] 09:18:47     INFO - PID 1531 | 1496222327633	Marionette	DEBUG	loaded listener.js
[task 2017-05-31T09:18:47.821242Z] 09:18:47     INFO - .
[task 2017-05-31T09:18:47.822230Z] 09:18:47     INFO - TEST-OK | /XMLHttpRequest/send-authentication-basic-repeat-no-args.htm | took 265ms
[task 2017-05-31T09:18:47.822299Z] 09:18:47     INFO - TEST-START | /XMLHttpRequest/send-authentication-basic-setrequestheader-and-arguments.htm
[task 2017-05-31T09:18:47.885133Z] 09:18:47     INFO - PID 1531 | 1496222327882	Marionette	DEBUG	loaded listener.js
[task 2017-05-31T09:18:48.037133Z] 09:18:48     INFO - .
[task 2017-05-31T09:18:48.037891Z] 09:18:48     INFO - TEST-OK | /XMLHttpRequest/send-authentication-basic-setrequestheader-and-arguments.htm | took 215ms
[task 2017-05-31T09:18:48.038597Z] 09:18:48     INFO - TEST-START | /XMLHttpRequest/send-authentication-basic-setrequestheader-existing-session.htm
[task 2017-05-31T09:18:48.107105Z] 09:18:48     INFO - PID 1531 | 1496222328102	Marionette	DEBUG	loaded listener.js
[task 2017-05-31T09:18:48.302770Z] 09:18:48     INFO - .
[task 2017-05-31T09:18:48.303686Z] 09:18:48     INFO - TEST-OK | /XMLHttpRequest/send-authentication-basic-setrequestheader-existing-session.htm | took 265ms
[task 2017-05-31T09:18:48.303761Z] 09:18:48     INFO - TEST-START | /XMLHttpRequest/send-authentication-basic-setrequestheader.htm
[task 2017-05-31T09:18:48.377280Z] 09:18:48     INFO - PID 1531 | 1496222328373	Marionette	DEBUG	loaded listener.js
[task 2017-05-31T09:18:48.568601Z] 09:18:48     INFO - .
[task 2017-05-31T09:18:48.568851Z] 09:18:48     INFO - TEST-OK | /XMLHttpRequest/send-authentication-basic-setrequestheader.htm | took 266ms
[task 2017-05-31T09:18:48.569406Z] 09:18:48     INFO - TEST-START | /XMLHttpRequest/send-authentication-basic.htm
[task 2017-05-31T09:18:48.627002Z] 09:18:48     INFO - PID 1531 | 1496222328625	Marionette	DEBUG	loaded listener.js
[task 2017-05-31T09:18:48.783944Z] 09:18:48     INFO - 
[task 2017-05-31T09:18:48.784275Z] 09:18:48     INFO - TEST-UNEXPECTED-FAIL | /XMLHttpRequest/send-authentication-basic.htm | XMLHttpRequest: send() - "Basic" authenticated requests with user name and password passed to open() - assert_equals: expected "DID" but got "DID-NOT"
[task 2017-05-31T09:18:48.784520Z] 09:18:48     INFO - @http://web-platform.test:8000/XMLHttpRequest/send-authentication-basic.htm:22:9
[task 2017-05-31T09:18:48.784835Z] 09:18:48     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1405:20
[task 2017-05-31T09:18:48.785900Z] 09:18:48     INFO - test@http://web-platform.test:8000/resources/testharness.js:497:9
[task 2017-05-31T09:18:48.785950Z] 09:18:48     INFO - @http://web-platform.test:8000/XMLHttpRequest/send-authentication-basic.htm:14:7
[task 2017-05-31T09:18:48.785989Z] 09:18:48     INFO - TEST-OK | /XMLHttpRequest/send-authentication-basic.htm | took 215ms
Priority: -- → P3
Blocks: xhr
Assignee: shuang → nobody

Shawn's analysis here seems to have been correct.

It looks as though some of the send/auth XHR web platform tests are mistakenly re-using the same auth1 landing. Since those landings are only meant to be valid once per session, the test should logically use a unique landing to avoid causing the next test to potentially fail.

I've got a patch on try here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f10a819a3b508aa2f644c6fe66818dd1c67b2c8

fix some WPTs to not re-use the same 'valid once per session' auth landing, which incorrectly causes test-failures.

Since I'm not sure if you'll see the request on Phabricator, I though I should ni? you here so you know about it, Anne.

Flags: needinfo?(annevk)

Reviewed, thanks for fixing these! (And I do get Phabricator email, just a bit swamped yesterday.)

Flags: needinfo?(annevk)
Pushed by twisniewski@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15affcdf9d0d
fix some WPTs to not re-use the same 'valid once per session' auth landing, which incorrectly causes test-failures. r=annevk

https://hg.mozilla.org/mozilla-central/rev/15affcdf9d0d

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → twisniewski
Component: DOM → DOM: Core & HTML
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15889 for changes under testing/web-platform/tests
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: