Closed
Bug 136721
Opened 23 years ago
Closed 22 years ago
News server should be pre-populated in Account Wizard after running auto-subscribe URLs.
Categories
(SeaMonkey :: MailNews: Account Configuration, defect)
SeaMonkey
MailNews: Account Configuration
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0.1
People
(Reporter: stephend, Assigned: naving)
References
()
Details
(Keywords: regression, Whiteboard: custrtm+ [adt2 rtm] [ETA 06/20])
Attachments
(2 files)
(deleted),
patch
|
racham
:
review+
tao
:
superreview+
jud
:
approval+
|
Details | Diff | Splinter Review |
(deleted),
text/plain
|
Details |
Build ID: 2002-04-10, all OSs.
Summary: news://news.mozilla.org/netscape.public.mozilla.mail-news
Steps to Reproduce:
1. With no previous news accounts set up, enter
news://news.mozilla.org/netscape.public.mozilla.mail-news into the browser's url
field.
2. Type in your username/email, hit Next.
3. Look at the Server name box on the next screen.
Expected Results:
It should say 'news.mozilla.org'
Actual Results:
It's blank. The reason it should be filled is this is an auto-subscribe URL.
Reporter | ||
Updated•23 years ago
|
Keywords: regression
Summary: News server should be pre-populated in Account Wizard after running autosubscribe URLs. → News server should be pre-populated in Account Wizard after running auto-subscribe URLs.
Reporter | ||
Comment 1•23 years ago
|
||
This is a regression that occured as a result of the new <wizard> widget. It's
not major, but it makes auto-subscribe a whole lot nicer.
Comment 2•23 years ago
|
||
marking nsbeta1- per mail triage.
Reporter | ||
Comment 3•23 years ago
|
||
*** Bug 147695 has been marked as a duplicate of this bug. ***
Renominate for [adt rtm]. This breaks CCK's NNTP pre-configuration.
Comment 5•22 years ago
|
||
Discussed in Mail News bug meeting. Decided to minus this bug.
Comment 6•22 years ago
|
||
Tao- can you confirm that this bug directly impacts feature we are building for
the road runner project? We need to have more discussions before we minus this-
the impact is potentially 1 MM users to Netscape.
Per Jeff: "From an enterprise standpoint this is an ADT1 issue under the
'requirement on PRD' and 'major loss of functionality' criteria.". This
regression breaks spec-ed feature in PRD.
Comment 8•22 years ago
|
||
Desired/correct functionality for customized clients
-Default unchecked
In New/Fresh Install:
- If a user leaves this unchecked, the homepage is left as is in the prefs
file. Default distributor home url (as set by cck tool) remains unchanged.
- If a user check this box, the home page is changed to home.netscape.com
address default to 7.0.
Acceptable senario for established End User with new custom install:
- If a user leaves this unchecked, the homepage is left as set by default
distributor.
IDEAL in this case for established End user with new custom install:
- User is presented with two check boxes, both default unchecked. NOTE: User can
leave unchecked or check one, but not both.
Box 1- Make my homepage xxxx (text set by distributor)
Box 2- Make Netscape.com my homepage
- If a user checks box 1, homepage is changed to url provided by distributor.
- If a user checks box 2, homepage is changed to netscape.com
- If user leaves both unchecked, homepage retained from old profile.
I realize this last one is an enhancement of a feature. I'd like to see what is
involved to make the ones above happen for RTM.
Comment 9•22 years ago
|
||
opps wrong bug. please ignore this comment- I had too many windows open at once.
Comment 10•22 years ago
|
||
reassigning to naving.
Assignee | ||
Comment 11•22 years ago
|
||
The fix is to assign the hostname value if we have one in the server page. I
had to initialize that ispData to null so that we can initialize pageData with
acct information from invalid acct.
Assignee | ||
Comment 12•22 years ago
|
||
bhuvan, Can I get r=? thx.
Comment 13•22 years ago
|
||
Hi, Naving: thanks for looking into this bug.
Hi, Bom-Shik: would you please verify that the patch also fix CCK's news server
setting problem? thx!
Attachment #87608 -
Flags: review+
Comment 14•22 years ago
|
||
Comment on attachment 87608 [details] [diff] [review]
proposed fix
r=bhuvan
Comment 16•22 years ago
|
||
Comment on attachment 87608 [details] [diff] [review]
proposed fix
I thought js variables were automatically initialized to null. The other change
looks fine, however, so sr=bienvenu.
Reporter | ||
Comment 17•22 years ago
|
||
bienvenu - see http://people.netscape.com/stephend/js.html for a null vs.
undefined testcase I wrote
Comment 18•22 years ago
|
||
Navin,
Also, I think you should add a try catch block around the new code so that cases
where there is no pageData for newsserver will not halt the wizard progress.
Bhuvan
Assignee | ||
Comment 19•22 years ago
|
||
I checked if there is no newsserver it throws the exception saying newsserver
has no properties but doesn't stall the wizard.
Assignee | ||
Comment 20•22 years ago
|
||
fixed on trunk
Comment 22•22 years ago
|
||
Let's get this verified on the trunk. blee, can you make sure this solves the
configuration tool's problems?
Comment 23•22 years ago
|
||
Trunk build 2002-06-17: WinMe, Linux RH 7.1, Mac 10.1.3
Verified Fixed, the news server was displayed in the Account Wizard using the
following test scenarios:
1. New profile, autoscribe: ok
2. New profile, configure for a Mail account, then autosubscribe: ok
3. Migrate a profile which is configured for mail and the "news" server.
Autosubscribe to news.mozilla.org: ok
4. Migrate a profile which is configured for news.mozilla.org, remove
news.mozilla.org, exit/restart, autosubscribe: ok
but it takes 15 minutes on my system for the Account Wizard to appear and 3-5
minutes on Esther's WinXP system. I will log this issue in a different bug.
Status: RESOLVED → VERIFIED
Comment 24•22 years ago
|
||
I tried this out by pointing 6/17 CCK to the blob installer of 06-17-12 trunk
bld, but NNTP server setting still does not not show up in the custom bld.
Comment 25•22 years ago
|
||
Comment 26•22 years ago
|
||
Per tao's suggestion, I copied newsaccount.rdf (created by CCK 6.2) in
/default/isp(/us) of 06-17-12 trunk bld and it displayed the custom content
correctly. That verifies this bug is fixed. Sorry about the confusion.
The .rdf file is attached here.
Comment 27•22 years ago
|
||
It probably doesn't skip the wizardpanels (as requested in the rdf file) still.
Skipping panels meaning jumping from identity page to Congratulations/Done page.
I have fixed this part in the patch for bug 144562.
Comment 28•22 years ago
|
||
Comment on attachment 87608 [details] [diff] [review]
proposed fix
has sr=bienvenu
Attachment #87608 -
Flags: superreview+
Updated•22 years ago
|
Attachment #87608 -
Flags: approval+
Comment 29•22 years ago
|
||
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+
Comment 30•22 years ago
|
||
adt1.0.1+ (on ADT's behalf) approval for checkin to the 1.0 branch. pls check
this in asap, then add the "fixed1.0.1" keyword.
Comment 32•22 years ago
|
||
Branch build 2002-06-21: WinMe, Linux RH 7.1, Mac 9.1
verified1.0.1
Keywords: fixed1.0.1 → verified1.0.1
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•