Closed
Bug 1367278
Opened 8 years ago
Closed 7 years ago
stylo: may_have_animations() is called against wrong element
Categories
(Core :: CSS Parsing and Computation, enhancement, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(1 file)
As Emilio suggested in bug 1366631 comment 17, when I added an assertion in may_have_animations() that checks the element is neither 'before' nor 'after', it revealed that we are calling may_have_animations for such pseudo elements. Initially I was trying to fix it in additional patch in bug 1366631, but I decided to handle it in a new bug.
Updated•8 years ago
|
Assignee: nobody → hikezoe
Priority: -- → P2
Assignee | ||
Comment 1•7 years ago
|
||
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8888147 [details]
Bug 1367278 - Call may_have_animations() for parent element in the case where the target is pseudo element.
https://reviewboard.mozilla.org/r/159062/#review164430
Nice! Thank you!
::: commit-message-eb1d9:3
(Diff revision 1)
> +Bug 1367278 - Call may_have_animations() for parent element in the case where the target is pseudo element. r?birtles
> +
> +In case of pseudo elements ElementHasAnimations is set to their parent element.
Nit: ... set on the parent element.
Attachment #8888147 -
Flags: review?(bbirtles) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Thank you!
https://github.com/servo/servo/pull/17793
Comment hidden (mozreview-request) |
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f5cc20c3be3
Call may_have_animations() for parent element in the case where the target is pseudo element. r=birtles
Comment 7•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•