Closed
Bug 1367299
Opened 8 years ago
Closed 7 years ago
stylo: Serialization is different for -webkit-radial-gradient
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | wontfix |
firefox56 | --- | wontfix |
firefox57 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file)
For: -webkit-radial-gradient(contain, red, blue)
gecko -> radial-gradient(closest-side, red, blue)
stylo -> -webkit-radial-gradient(center center, contain, red, blue)
I have no idea which is expected... I suspect stylo one.
Assignee | ||
Comment 1•7 years ago
|
||
It seems different browsers give different answer for this:
gecko: radial-gradient(closest-side, red, blue)
stylo: -webkit-radial-gradient(center center, contain, red, blue)
blink: -webkit-radial-gradient(center, ellipse contain, red, blue)
edge : -webkit-radial-gradient(contain, red, blue)
I guess all of them are effectively identical.
I tried to unconditionally set cssGradient->mIsLegacySyntax if there is webkit-prefix, but it seems the serialization code in nsCSSValue doesn't handle this case correctly, and generates "-webkit-radial-gradient(closest-side, red, blue)", which is probably invalid as a legacy syntax.
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Comment 3•7 years ago
|
||
Bug 1380259 fixes the serialization differences for computed values, but not for specified values. I am reopening this bug to track the work required to fix this for specified values.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee | ||
Comment 4•7 years ago
|
||
I'll take care of this.
Setting P1 because it is the last blocker for enabling more mochitests.
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8893690 [details]
Bug 1367299 - Allow -webkit-radial-gradient to be serialized in different way with stylo.
https://reviewboard.mozilla.org/r/164812/#review170414
Attachment #8893690 -
Flags: review?(dholbert) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4289bf021340
Allow -webkit-radial-gradient to be serialized in different way with stylo. r=dholbert
Comment 8•7 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•7 years ago
|
status-firefox55:
--- → wontfix
status-firefox56:
--- → wontfix
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•