Closed
Bug 1367338
Opened 7 years ago
Closed 7 years ago
Netmonitor expand/collapse icon should be disabled (and not hidden) when request list is empty
Categories
(DevTools :: Netmonitor, defect, P3)
DevTools
Netmonitor
Tracking
(firefox55 verified, firefox56 verified)
VERIFIED
FIXED
Firefox 56
People
(Reporter: jdescottes, Assigned: Honza)
Details
Attachments
(2 files)
(deleted),
image/gif
|
Details | |
(deleted),
text/x-review-board-request
|
jdescottes
:
review+
jcristau
:
approval-mozilla-beta+
|
Details |
STRs:
See attached GIF, the expand/collapse icon disappears & appears when using the Filter input, which makes the UI feel shaky. We should simply disable it if there are no requests.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8870734 [details]
Bug 1367338 - Do not hide collapse button;
https://reviewboard.mozilla.org/r/142220/#review145886
Great! That was easy :D
Attachment #8870734 -
Flags: review?(jdescottes) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f93ee3d17d7e
Do not hide collapse button; r=jdescottes
Comment 4•7 years ago
|
||
Comment on attachment 8870734 [details]
Bug 1367338 - Do not hide collapse button;
Approval Request Comment
[Feature/Bug causing the regression]: New netmonitor search feature
[User impact if declined]: see https://bugzilla.mozilla.org/attachment.cgi?id=8870733
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: css removal
[String changes made/needed]:
Attachment #8870734 -
Flags: approval-mozilla-beta?
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Comment 6•7 years ago
|
||
I have reproduced this bug with Nightly 55.0a1 (2017-05-24) on Windows 10 , 64 Bit !
This bug's fix is Verified with latest Nightly 56.0a1 !
Build ID 20170705030206
User Agent Mozilla/5.0 (Windows NT 10.0; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0
[bugday-20170705]
Comment 7•7 years ago
|
||
Comment on attachment 8870734 [details]
Bug 1367338 - Do not hide collapse button;
netmonitor css fix, beta55+
Attachment #8870734 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•7 years ago
|
||
bugherder uplift |
status-firefox55:
--- → fixed
Comment 9•7 years ago
|
||
Cipri, you might want to look at this as well.
QA Whiteboard: [good first verify]
Comment 10•7 years ago
|
||
I have reproduced this bug with Nightly 55.0a1 (2017-05-24) (64-bit) on Ubuntu 16.04 LTS!
This bug's fix is verified with latest Beta and latest Nightly!
Build ID : 20170706155135
User Argent : Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID : 20170707100138
User Argent : Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [good first verify] → [good first verify] [bugday-20170705]
Comment 11•7 years ago
|
||
I have reproduced this Bug with Nightly 55.0a1 (2017-05-24) on Windows 10, 64 Bit!
The bug's fix is now verified on latest Beta 55.0b7
Build ID 20170706085221
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
QA Whiteboard: [good first verify] [bugday-20170705] → [good first verify] [bugday-20170705] [testday-20170707]
Comment 12•7 years ago
|
||
This bug is verified fixed on latest Nightly 56.0a1 (20170707030206) and 55 beta 7 (20170706085221) under the following OSes: Windows 10 x64, Mac OS X 10.11.6 and Ubuntu 16.04 x64 LTS.
Thank you, Mohammad and Tanvir for verifying this bug!
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•