Luca Greco [:rpl] [:luca] [:lgreco] Reporter
	Description • 7 years ago

WebExtensions addons may want to listen for webRequest related to websocket connections (which use the ws and wss as the protocol names), e.g. uBlock-Origin is one of these extensions:

- https://github.com/gorhill/uBlock/blob/ca32a693df510fb1018ecde2e8a2412f622aab3c/platform/chromium/vapi-background.js#L1099-L1119

Currently, when trying to add a webRequest listener using ws or wss urls in the event filters logs, the following errors are logged in the console:

- Invalid match pattern: 'ws://*/*'
- Invalid match pattern: 'wss://*/*'
- The webRequest.addListener filter doesn't overlap with host permissions

	Shane Caraveo (:mixedpuppy) Assignee
	Comment 1 • 7 years ago

Websockets work fine in webrequest, the urls show up under http/s.  We could change the url for addons listening on websockets, but I wonder where else that url could end up being an issue.

In any case this waits on bug 1368102

	Kris Maglione [:kmag]
	Comment 3 • 7 years ago
mozreview-review

Comment on attachment 8875399 [details]
Bug 1367478 support websocket ws/wss protocol in matchpattern,

https://reviewboard.mozilla.org/r/146840/#review151538

	Pulsebot
	Comment 4 • 7 years ago

Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/62e44a827308
support websocket ws/wss protocol in matchpattern, r=kmag

	Carsten Book [:Tomcat]
	Comment 5 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/62e44a827308