Closed
Bug 1367525
Opened 7 years ago
Closed 7 years ago
Remove extra error logging during device disconnect
Categories
(Firefox :: Sync, enhancement, P1)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: udara.weera, Assigned: udara.weera)
References
Details
Attachments
(1 file)
Remove logs when disconnected id is different than the current device id.
FXA servers will now always send notifications to all devices, when any device is disconnected, so we don't need error logging for this scenario anymore.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8870968 -
Flags: review?(eoger)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8870968 [details]
Bug 1367525 - Remove extra error logging during device disconnect.
https://reviewboard.mozilla.org/r/142532/#review146136
LGTM, thanks!
r+ with a fix of the commit message nitpick.
::: commit-message-37d77:1
(Diff revision 1)
> +Bugzilla #1367525 - Remove extra error logging during device disconnect
The format we use on the gecko tree is as follows:
Bug <Bug number> - <Commit message>. r?<reviewer(s)>
In that case it would be:
Bug 1367525 - Remove extra error logging during device disconnect. r?eoger
Attachment #8870968 -
Flags: review?(eoger) → review+
Comment 3•7 years ago
|
||
Don't forget to assign yourself on the bug when you're working on it ;-)
Assignee: nobody → udara.weera
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Updated•7 years ago
|
Priority: -- → P1
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
I don't understand why we want to remove this.
Comment 6•7 years ago
|
||
Mark:
https://github.com/mozilla/fxa-auth-server/issues/1777
It doesn't hurt to do it anyway, we might need that message in the future.
Comment 7•7 years ago
|
||
Ah, I see, thanks
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8870968 [details]
Bug 1367525 - Remove extra error logging during device disconnect.
https://reviewboard.mozilla.org/r/142532/#review146562
Attachment #8870968 -
Flags: review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb3190b6eb58
Remove extra error logging during device disconnect. r=eoger
Comment 10•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in
before you can comment on or make changes to this bug.
Description
•