Closed
Bug 1367570
Opened 8 years ago
Closed 8 years ago
Vertex Attribs left in invalid state by Nvidia Linux driver
Categories
(Core :: Graphics: CanvasWebGL, enhancement, P1)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: svargas, Assigned: svargas)
References
Details
(Whiteboard: gfx-noted)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Firefox currently fails the WebGL Disabled Vertex Attrib Test and the gl calls test on 64bit Linux when using the proprietary Linux Nvidia driver.
The Linux proprietary NVidia driver leaves vertex attribs 1, 2, and 3 at invalid states (not opaque black) causing the test to fail.
Tests:
https://www.khronos.org/registry/webgl/conformance-suites/1.0.3/conformance/attribs/gl-disabled-vertex-attrib.html?webglVersion=1
https://www.khronos.org/registry/webgl/conformance-suites/1.0.3/conformance/state/gl-get-calls.html?webglVersion=1
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → svargas
|
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8871019 -
Flags: review?(jgilbert)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8871019 [details] [diff] [review]
0001-Bug-1367570-Explicitly-set-vertex-attribs-1-3-to-opa.patch
Review of attachment 8871019 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/gl/GLContext.cpp
@@ +903,5 @@
> }
> + // Bug 1367570. Explicitly set vertex attributes [1,3] to opaque
> + // black because Nvidia doesn't do it for us.
> + if (mVendor == GLVendor::NVIDIA) {
> + for (size_t i=1; i <= 3; ++i) {
`i = 1` with spaces
Attachment #8871019 -
Flags: review?(jgilbert) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Attachment #8871019 -
Attachment is obsolete: true
|
|
||
Updated•8 years ago
|
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c2e66552c70
Explicitly set vertex attribs [1,3] to opaque black - r=jgilbert
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•