Closed Bug 1367627 Opened 7 years ago Closed 7 years ago

Show an overlay of grid areas in Grid Highlighter

Categories

(DevTools :: Inspector, enhancement)

Product:
DevTools
Component:
Inspector
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox55 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- verified

People

(Reporter: micah, Assigned: micah)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1367627 - Show overlay of grid areas in Grid Highlighter.
(deleted), text/x-review-board-request
gl
: review+
Details
Add a checkbox in the grid highlighter's display settings so that we can toggle showing the grid areas of a grid container.
Assignee: nobody → tigleym
Blocks: 1347964
Status: NEW → ASSIGNED
Blocks: dt-grid
No longer blocks: 1347964
Flags: qe-verify+
Comment on attachment 8872092 [details] Bug 1367627 - Show an overlay of grid areas in Grid Highlighter. https://reviewboard.mozilla.org/r/143594/#review147670
Attachment #8872092 - Flags: review?(gl)
Comment on attachment 8872092 [details] Bug 1367627 - Show an overlay of grid areas in Grid Highlighter. https://reviewboard.mozilla.org/r/143594/#review148492 ::: devtools/client/inspector/grids/test/browser_grids_display-setting-show-grid-areas.js:6 (Diff revision 2) > +/* Any copyright is dedicated to the Public Domain. > + http://creativecommons.org/publicdomain/zero/1.0/ */ > + > +"use strict"; > + > +// Tests that the 'Extend grid lines infinitely' grid highlighter setting will update 'Display grid areas' ::: devtools/server/actors/highlighters/css-grid.js:1141 (Diff revision 2) > +/** > + * Render grid area name on the containing grid area cell. > + * > + * @param {Object} fragment > + * The grid fragment of the grid container. > + * Remove this line
Attachment #8872092 - Flags: review?(gl)
Comment on attachment 8872092 [details] Bug 1367627 - Show an overlay of grid areas in Grid Highlighter. https://reviewboard.mozilla.org/r/143594/#review148494
Attachment #8872092 - Flags: review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/37a4d90166ba Show overlay of grid areas in Grid Highlighter. r=gl
Comment on attachment 8873254 [details] Bug 1367627 - Show overlay of grid areas in Grid Highlighter. https://reviewboard.mozilla.org/r/144708/#review148870
Attachment #8873254 - Flags: review?(gl) → review+
Attachment #8872092 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/37a4d90166ba
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have reproduced this bug with Nightly 55.0a1 (2017-05-24) on Windows 8.1 , 64 Bit ! This bug's fix is Verified with latest Nightly 55.0a1 ! Build ID 20170602030204 User Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0 [bugday-20170531]
I have reproduced this Bug with Nightly 55.0a1 (2017-05-24) on Ubuntu 16.04 LTS! The bug's fix is verified with latest Beta! Build ID 20170706155135 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
QA Whiteboard: [testday-20170707]
As per Comment 11 & Comment 12, I am marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
Thanks Sajedul and Mohammad for your testing!
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: