Closed Bug 1367846 Opened 8 years ago Closed 7 years ago

Audio controls not visible at FT podcast

Categories

(Toolkit :: Video/Audio Controls, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox-esr45 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- wontfix
firefox54 --- wontfix
firefox55 --- fixed
firefox56 --- fixed

People

(Reporter: dholbert, Assigned: ralin)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [webcompat][fixed by bug 1373537])

STR: 1. Visit http://podcast.ft.com/s/ft-alphachat/ EXPECTED RESULTS: Audio controls should be visible below each podcast blurb. ACTUAL RESULTS: Audio controls not visible. This was originally filed as https://webcompat.com/issues/6876 Regression range points to bug 1271765. Still broken in current Nightly.
Flags: needinfo?(ralin)
This might be a dupe of bug 1362146 (which manifests similarly), though this FT page doesn't have any "max-width" / "max-height" styling (which at first glance it seems bug 1362146 depends on). Adam's seeing if he can come up with a reduced testcase, too (thanks Adam!)
Keywords: regression
(Looks like this affects all versions starting from Firefox 53, based on when bug 1271765 landed.)
Created a reduced testcase. The audio controls don't appear with width and height defined: https://jsfiddle.net/8y841azc/ They do appear with only width defined: https://jsfiddle.net/5m725ny8/
Whiteboard: [webcompat]
It's likely a dupe of bug 1362146, that the controls will hide entirely when its height could not fit in the given height(max-height). See for more info: https://bugzilla.mozilla.org/show_bug.cgi?id=1362146#c3. In case not the same case, I'd wait for bug 1362146 and see if problem is solved then. Thank you Daniel, Adam
Flags: needinfo?(ralin)
Depends on: 1362146
Blocks: 1368639
No longer depends on: 1362146
Hi Adam, Bug 1373537 was landed yesterday and it in some way addressed the max-height problem, could you help me to verify if the issue is still on http://podcast.ft.com/s/ft-alphachat/ ? Thanks.
Flags: needinfo?(astevenson)
I can still reproduce the issue in Firefox 56.0a1 (2017-06-30) (64-bit) for OSX.
Flags: needinfo?(astevenson)
ah! bug 1373537 was actually landed this morning, so 2017-07-01 or m-c would be the right build applied that patch.
OK, will test again tomorrow.
Flags: needinfo?(astevenson)
Too late for 54. Mark 54 won't fix.
This is now working for me in Firefox 56.0a1 (2017-07-04) for OSX. Let's close this as fixed. Thanks!
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(astevenson)
Resolution: --- → FIXED
Thank you Adam!
Whiteboard: [webcompat] → [webcompat][fixed by bug 1373537]
Depends on: 1373537
Assignee: nobody → ralin
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.