Closed Bug 1368131 Opened 7 years ago Closed 2 years ago

BrowserTestUtils.removeTab should resolve once the <tab> node has been fully removed

Categories

(Firefox :: General, enhancement)

Product:
Firefox
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: mconley, Unassigned)

Details

BrowserTestUtils.removeTab seems to resolve once the last SessionStore:update message comes up from the tab, but this can race with the tab close animation (if an animation is occurring), meaning that the tab node might still be in the tab strip by the time that BrowserTestUtils.removeTab resolves.

This burned me in my in my reflow tests, because it meant that the DOM was being dirtied at an unexpected time (some amount of time after removeTab resolves).

We should make removeTab wait until the tab has been fully removed from the DOM before resolving.

Is this bug still valid? Bug 1442465 removed the "SessionStore:update message".

Flags: needinfo?(mconley)

This appears to have not been an issue in recent memory, so let's close this for now.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(mconley)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.