Closed Bug 1368300 Opened 8 years ago Closed 7 years ago

Intermittent browser/components/customizableui/test/browser_photon_customization_context_menus.js | disabled state for #toolbar-context-bookmarkAllTabs - Got true, expected false

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1336839

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])

:Gijs - I think this failure started with your changes in bug 1354078. Can you make this test more reliable?
Blocks: 1354078
Flags: needinfo?(gijskruitbosch+bugs)
Whiteboard: [stockwell needswork]
Depends on: 1381430
(In reply to Geoff Brown [:gbrown] from comment #5) > :Gijs - I think this failure started with your changes in bug 1354078. Can > you make this test more reliable? This doesn't make sense. That's when the test was added, but it had exactly the same issues as bug 1336839, because the test is basically a duplicate but using photon rather than non-photon menus. It wasn't frequent at all at the time of bug 1354078. As noted in bug 1336839, this increased in frequency at the end of June. The only related change in the menus was bug 1378427, but that happened a week ago, not at the end of June. It seems more likely this has to do with how we bookmark things or how we open new tabs / remoteness-change them (considering this isn't failing at all in non-e10s). The screenshots show that the newly opened tab hasn't loaded example.com yet, so that would cause the 'bookmark all tabs' code to not consider the new page loaded, meaning there's nothing to bookmark. I've tried seeing if using the BrowserTestUtils here helps, but I'm not sure it will. I can't reproduce the failure locally even with --run-until-failure, so it's hard to know what else to try. https://treeherder.mozilla.org/#/jobs?repo=try&revision=504517374d4b7baef8ba9303fbe3c176f8ab878e
Flags: needinfo?(gijskruitbosch+bugs)
Looks like this got fixed by my patch in bug 1336839. We can reopen if this reoccurs.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Whiteboard: [stockwell needswork] → [stockwell fixed]
You need to log in before you can comment on or make changes to this bug.