Closed
Bug 1368325
Opened 7 years ago
Closed 7 years ago
js::gc::BarriersAreAllowedOnCurrentThread() shows up in performance profiles
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: smaug, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
js::gc::BarriersAreAllowedOnCurrentThread() is called in some very hot code paths, like inside GetWrapper.
Is there any way to avoid the tls lookup?
|
Assignee | |
Comment 1•7 years ago
|
||
I've noticed this too.
It's the MOZ_DIAGNOSTIC_ASSERT in ExposeGCThingToActiveJS so it does not affect release/beta, but it would help profiling to not have these perf differences between Nightly and beta.
We can remove this code now. We'll have to put it back if we ever revive bug 1308039, but that's fine.
|
|
Assignee | |
Comment 3•7 years ago
|
||
This removes BarriersAreAllowedOnCurrentThread and related code.
Comment on attachment 8878025 [details] [diff] [review]
Patch
Review of attachment 8878025 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8878025 -
Flags: review?(wmccloskey) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/370bb186e98f
Remove JSContext::allowGCBarriers and related code as it's not used anywhere. r=billm
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•