Matthew Wein [:mattw] Reporter
	Description • 7 years ago

The following information should be provided to FindProxyForURL:

 - tabID {integer} the current tab ID for the page loaded.
 - isPrivateMode {boolean} whether or not the window is in private browsing mode.
 - windowID {integer} the ID of the current browser window.
 - userContextID {integer} the user context ID for the tab's container.


For more information, see the proxy API design document: https://docs.google.com/document/d/1W45o5X2bFRPrTaQDFp9IzTJ8njCVfEgyENS7i2owaUI/edit?usp=sharing

	Shane Caraveo (:mixedpuppy) Assignee
	Comment 1 • 7 years ago

Need to document some use cases for new data, lets make sure they will be useful.  So, I'll start with a couple:

with isPrivateMode a PAC may
- choose to let all private windows go direct
- use a specific proxy for private browsing

with userContextID a PAC may
- proxy "work" through a different server than "banking"

I'm failing to come up with a simple use case for tabID or windowID given these IDs will have no value in the PAC script without adding more WE APIs to it.

Since this is now a P1 bug, it seems there should be better definition for what is needed and useful.

	Eric Jung [:ericjung]
	Comment 2 • 7 years ago

Changing to P2 since much of this info wasn't available prior to WebExtensions.

> I'm failing to come up with a simple use case for tabID or windowID
A long-requested feature from proxy addons has been "proxy-per-tab" or "proxy-per-window". In other words, use proxy A for this tab and proxy B for another tab.

I think some of this contextual info is available by using nsIProtocolProxyService.registerChannelFilter() instead of nsIProtocolProxyService.registerFilter() as we are currently doing in ProxyScriptContext.jsm. registerChannelFilter() hands you an nsIChannel instance which, IIRC, can be used to get tab or window data (load groups?)

	Eric Jung [:ericjung]
	Comment 3 • 7 years ago

> registerChannelFilter() hands you an nsIChannel instance
through the applyFilter() callback. I opened a bug for it 9 years ago (bug 436344), and it was done 3 years ago. I never got around to using it but I know Tor Browser does.

	Salar
	Comment 4 • 7 years ago

> I'm failing to come up with a simple use case for tabID or windowID 
In addition to Eric's response, another use case would be `proxy per triggered origin` which in simple words would allow the extension to enable proxy for certain domains and all its resources that are called from it.
(Is origin url is extractable from tabID?)

This is highly is required for an extension that I'm working on right now.

	Shane Caraveo (:mixedpuppy) Assignee
	Comment 5 • 7 years ago

If this is possible in bug 1409878 we'll try to add it.