Closed Bug 1368632 Opened 7 years ago Closed 7 years ago

Crash reports from new DevEdition based on beta don't have right version information

Categories

(Socorro :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philipp, Assigned: adrian)

References

Details

Attachments

(2 files)

This is what shows up as about:support information about DevEdition 54.0b11: Application Basics ------------------ Name: Firefox Version: 54.0b11 Build ID: 20170525155044 Update Channel: aurora User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0 OS: Windows_NT 6.1 Multiprocess Windows: 0/1 (Disabled) Google Key: Found Mozilla Location Service Key: Found Safe Mode: false however a submitted crash report from this build will just show up as version 54.0 instead of 54.0b11: bp-1bfe2490-af93-4d18-9643-8b1d50170530 it's already showing up like this when you inspect the details of the report in the breakpad app before you submit the report to mozilla.
Component: Crash Reporting → General
Product: Toolkit → Socorro
Summary: Crash reports from new DevEdition based on beta don't include right version information → Crash reports from new DevEdition based on beta don't have right version information
Version: 54 Branch → unspecified
Blocks: dawn-project
Assignee: nobody → adrian
I found two problems related to this: 1. the version 54.0b11 doesn't exist in our product_versions table; 2. our rule that corrects version numbers only applies to crash reports on the beta channel. #2 is simple to fix. I have no idea why #1 happens. I suspect there might be a rule somewhere in our stored procedures that considers that version number to be invalid for the aurora channel. 3 solutions: 1. change the release channel of the DevEdition to make it be beta; 2. figure out the two problems above on the Socorro side and make this system work for aurora crashes as well; 3. entirely rework how Socorro deals with products, versions and builds because it's a huge mess.
(In reply to Adrian Gaudebert [:adrian] from comment #2) > 3 solutions: > 1. change the release channel of the DevEdition to make it be beta; > ... the "aurora" update channel is still needed to provide the proper (& unthrottled) updates to devedition users i guess?
Flags: needinfo?(bhearsum)
(In reply to [:philipp] from comment #3) > (In reply to Adrian Gaudebert [:adrian] from comment #2) > > 3 solutions: > > 1. change the release channel of the DevEdition to make it be beta; > > ... > > the "aurora" update channel is still needed to provide the proper (& > unthrottled) updates to devedition users i guess? Unless we decide we can do repacks instead of rebuilds, DevEdition will continue to have its own update channel. We may change it from "aurora" to "devedition" (or something like that) at some point, but it will not be "beta".
Flags: needinfo?(bhearsum)
Ah, but that means that from now on, all versions on the "aurora" channel will effectively be DevEdition builds, using the "bX" notation, right? I was afraid of mixing regular aurora builds with the new one, but I guess DevEdition is the "regular" now.
yes, the only builds that mozilla releases on the aurora channel going forward devedition builds based on beta and with the beta versioning scheme. the switch-over happened on the aurora channel with buildid 20170525155044 (which was 54.0b11).
Sylvestre said he will help get this one resolve asap. The main issue is 55.0 beta1 will be pushed to old-aurora so we need to be able to reliably gauge socorro based crashes and crash rates. if we are not setup to do that, it will hinder our ability to stage rollout.
Flags: needinfo?(sledru)
To do: 1. figure out why version 54.0b11 doesn't exist in our product_versions table and fix that 2. figure out is applying the version renaming logic to non-beta crash reports will have an impact on crashes coming from older aurora builds 3. enable version renaming logic to aurora builds as well as beta
Flags: needinfo?(sledru)
4. in the future, get ride of the aurora word to display beta/devedition instead (but this isn't a blocker for this bug)
Good news, this is actually working! For some reason, the crash report that Philipp links to in #0 has a release channel of "aurora", but it seems that recent crash reports do not, and instead announce they come from the "beta" channel. Version 54.0b11 does exist in our database, and unlike what I expected, it has a build type of "beta". So, as far as I can tell, all's for the best, in the best of all possible worlds. :) Please reopen if something is wrong.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
hi adrian, it doesn't seem to work yet, this is a report that i just triggered from devedition 54.0b14: bp-4d35aa9c-29a8-476b-bd69-acfba0170612
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
OK, I'm a bit at a loss here. Why do some builds report they are on the beta channel, and others on the aurora channel? For example, all builds of 54.0b13 are on the beta channel: https://crash-stats.mozilla.com/search/?product=Firefox&version=54.0b13&_facets=release_channel#facet-release_channel Do we have two different "branches" (for lack of a better word) of Firefox, one on the beta channel, and one on the aurora / DevEdition channel, that share the same version numbers at the same time?
exactly - two different update channels (beta & aurora), but those builds share the same version numbers. so ideally when we search for 54.0b13 on socorro or look in the top crash dashboard, we'd get crashes from both those builds.
We don't have any data about build 20170605125726 in our database. I suspect that is because this folder has no JSON data: https://archive.mozilla.org/pub/firefox/releases/54.0b13/win32/en-US/ Any idea why that is?
oh, the folder structure for these devedition builds also has changed - they are located at https://archive.mozilla.org/pub/devedition/releases/
(In reply to [:philipp] from comment #15) > oh, the folder structure for these devedition builds also has changed - they > are located at https://archive.mozilla.org/pub/devedition/releases/ Just in case there's any confusion still: they are now using the same directory structure as Beta, Release, and ESR (whereas they used to use the "nightly" style that mozilla-central/Nightly continues to use).
(In reply to Sylvestre Ledru [:sylvestre] from comment #9) > 4. in the future, get ride of the aurora word to display beta/devedition > instead (but this isn't a blocker for this bug) I was unaware of this discussion but I reported bug 1373164 which is about exactly that topic.
Commit pushed to master at https://github.com/mozilla-services/socorro https://github.com/mozilla-services/socorro/commit/20dbdca3b47d272acc94ce2a0e15e56da8e67389 Fixes bug 1368632 - Applied version correcting logic to aurora crash … (#3810) * Fixes bug 1368632 - Applied version correcting logic to aurora crash reports. * Better comments. * typo
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Commit pushed to master at https://github.com/mozilla-services/socorro https://github.com/mozilla-services/socorro/commit/591badfbc7f77c18360f07e3a8fc55b33310a728 Bug 1368632 - Added DevEdition to the repositories to parse in ftpscraper. (#3811) This new repository contains information about the builds of the freshly created DevEdition channel. We need to parse it in order to be able to show correct version numbers in Socorro.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: