Closed Bug 1369214 Opened 7 years ago Closed 7 years ago

test_getProcess.html implicitly depends on Services being loaded for process scripts

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

This test runs a process script which references Services, but does not explicitly define it.
Attachment #8873227 - Flags: review?(poirot.alex)
Comment on attachment 8873227 [details] Bug 1369214 - test_getProcess.html should explicitly require Services in its process script. https://reviewboard.mozilla.org/r/144676/#review148556 ::: devtools/server/tests/mochitest/test_getProcess.html:121 (Diff revision 1) > } > > function processScript() { > + let Cu = Components.utils; > + let {require} = Cu.import("resource://devtools/shared/Loader.jsm", {}); > + let Services = require("Services"); Thanks, good catch! It should be fine using Cu.import(Services.jsm) as well.
Attachment #8873227 - Flags: review?(poirot.alex) → review+
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42d88860d41a test_getProcess.html should explicitly require Services in its process script. r=ochameau
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/614f1d397f4b Fix ESLint doublequote failures in test_getProcess.html on a CLOSED TREE.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: