Open Bug 1369611 Opened 7 years ago Updated 2 years ago

stylo: improve the setup for deciding whether a selector with an id in it is a revalidation selector

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Version:
53 Branch
Type:
enhancement

Tracking

()

Tracking Flags:
Tracking Status
firefox57 --- wontfix

People

(Reporter: bzbarsky, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Right now (with bug 1369584 fixed) we just put all selectors with an id in the revalidation selector list. We can do better. As https://github.com/servo/servo/pull/17055#issuecomment-304436932 points out, it's enough to insert the ones which contain an id which is not present in the relevant rulehash (selectormap). I'm deferring this for now in the interests of getting bug 1369584 landed, but we should really do it. Though it might make sense to wait until after bug 1362538.
Assignee: nobody → bzbarsky
Priority: -- → P1
Blocks: 1373362
Priority: P1 → P4
status-firefox57=wontfix unless someone thinks this bug should block 57
status-firefox57: --- → wontfix

Emilio, do you think this is still worth doing in the current world?

Flags: needinfo?(emilio)

I think https://github.com/servo/servo/pull/17966 improved this substantially. I haven't seen revalidation stuff much in profiles, but when I see it and dig it's mostly regular attribute selectors rather than id / classes.

Flags: needinfo?(emilio)

OK. Maybe we should just wontfix this... I would have thought "#foo stuff" rules would appear a bunch on web pages...

Assignee: bzbarsky → nobody
Priority: P4 → --
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.