3 occurrences: ../../../../../../../mobile/android/base/resources/values/themes.xml:117: android:colorPrimary requires API level 21 (current min is 15) 114 <!-- Set the app's title bar color in the recent app switcher. 115 116 Note: We'd prefer not to show up in the recent app switcher (bug 1137928). --> 117 <item name="android:colorPrimary">@color/text_and_tabs_tray_grey</item> 118 <!-- We display the overlay on top of other Activities so show their status bar. --> 119 <item name="android:statusBarColor">@android:color/transparent</item> Applies to variants: localOldAustralisDebug, localOldAustralisRelease, localOldPhotonDebug, localOldPhotonRelease, officialAustralisDebug, officialAustralisRelease, officialPhotonDebug, officialPhotonRelease Does not apply to variants: localAustralisDebug, localAustralisRelease, localPhotonDebug, localPhotonRelease ../../../../../../../mobile/android/base/resources/values/themes.xml:119: android:statusBarColor requires API level 21 (current min is 15) 116 Note: We'd prefer not to show up in the recent app switcher (bug 1137928). --> 117 <item name="android:colorPrimary">@color/text_and_tabs_tray_grey</item> 118 <!-- We display the overlay on top of other Activities so show their status bar. --> 119 <item name="android:statusBarColor">@android:color/transparent</item> 120 </style> 121 Applies to variants: localOldAustralisDebug, localOldAustralisRelease, localOldPhotonDebug, localOldPhotonRelease, officialAustralisDebug, officialAustralisRelease, officialPhotonDebug, officialPhotonRelease Does not apply to variants: localAustralisDebug, localAustralisRelease, localPhotonDebug, localPhotonRelease ../../../../../../../mobile/android/base/resources/values/themes.xml:145: android:paddingEnd requires API level 17 (current min is 15) 142 </style> 143 <style name="BookmarkToolbarStyle" parent="@style/Widget.AppCompat.Toolbar"> 144 <item name="android:paddingRight">5dp</item> 145 <item name="android:paddingEnd">5dp</item> 146 </style> 147 Applies to variants: localOldAustralisDebug, localOldAustralisRelease, localOldPhotonDebug, localOldPhotonRelease, officialAustralisDebug, officialAustralisRelease, officialPhotonDebug, officialPhotonRelease Does not apply to variants: localAustralisDebug, localAustralisRelease, localPhotonDebug, localPhotonRelease

Comment on attachment 8879892 [details] Bug 1369654 - Fix lint: NewApi issues in themes.xml; https://reviewboard.mozilla.org/r/151292/#review156238 LGTM

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3605c8cdc4a7 Fix lint: NewApi issues in themes.xml; r=maliu

(In reply to Teng-pao Yu [:tyu] from comment #0) > 3 occurrences: > > ../../../../../../../mobile/android/base/resources/values/themes.xml:117: > android:colorPrimary requires API level 21 (current min is 15) > > 114 <!-- Set the app's title bar color in the recent app switcher. > 115 > 116 Note: We'd prefer not to show up in the recent app > switcher (bug 1137928). --> > 117 <item > name="android:colorPrimary">@color/text_and_tabs_tray_grey</item> > 118 <!-- We display the overlay on top of other Activities so show > their status bar. --> > 119 <item > name="android:statusBarColor">@android:color/transparent</item> > > Applies to variants: localOldAustralisDebug, localOldAustralisRelease, > localOldPhotonDebug, localOldPhotonRelease, officialAustralisDebug, > officialAustralisRelease, officialPhotonDebug, officialPhotonRelease > Does not apply to variants: localAustralisDebug, localAustralisRelease, > localPhotonDebug, localPhotonRelease > ../../../../../../../mobile/android/base/resources/values/themes.xml:119: > android:statusBarColor requires API level 21 (current min is 15) > > 116 Note: We'd prefer not to show up in the recent app > switcher (bug 1137928). --> > 117 <item > name="android:colorPrimary">@color/text_and_tabs_tray_grey</item> > 118 <!-- We display the overlay on top of other Activities so show > their status bar. --> > 119 <item > name="android:statusBarColor">@android:color/transparent</item> > 120 </style> > 121 > > Applies to variants: localOldAustralisDebug, localOldAustralisRelease, > localOldPhotonDebug, localOldPhotonRelease, officialAustralisDebug, > officialAustralisRelease, officialPhotonDebug, officialPhotonRelease > Does not apply to variants: localAustralisDebug, localAustralisRelease, > localPhotonDebug, localPhotonRelease > ../../../../../../../mobile/android/base/resources/values/themes.xml:145: > android:paddingEnd requires API level 17 (current min is 15) > > 142 </style> > 143 <style name="BookmarkToolbarStyle" > parent="@style/Widget.AppCompat.Toolbar"> > 144 <item name="android:paddingRight">5dp</item> > 145 <item name="android:paddingEnd">5dp</item> > 146 </style> > 147 > > Applies to variants: localOldAustralisDebug, localOldAustralisRelease, > localOldPhotonDebug, localOldPhotonRelease, officialAustralisDebug, > officialAustralisRelease, officialPhotonDebug, officialPhotonRelease > Does not apply to variants: localAustralisDebug, localAustralisRelease, > localPhotonDebug, localPhotonRelease Hmm. The "local" and "localOld" variants are developer only -- they really don't count. Only "official" variants count. The comments in mobile/android/app/build.gradle try to explain why we have the developer-only versions, but we're seeing non-trivial issues (especially around linting) with them. We might have to drop them. In any case, this should radiate some information about these variants to some of the active Fennec developers, and you folks can inform our decisions about keeping or removing them.