Closed Bug 1369658 Opened 7 years ago Closed 7 years ago

Remove support for running subconfigures in parallel

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

Bug 1358023 and bug 1363992 removed the last uses of subconfigure other than js/src. We don't need all the machinery to run subconfigures in parallel anymore. Further simplifications can probably be done, but let's keep things simple for now.
Comment on attachment 8873751 [details] Bug 1369658 - Remove support for running subconfigures in parallel. https://reviewboard.mozilla.org/r/145160/#review149266
Attachment #8873751 - Flags: review?(gps) → review+
Comment on attachment 8873752 [details] Bug 1369658 - Print out subconfigure output while it runs. https://reviewboard.mozilla.org/r/145162/#review149270 ::: build/subconfigure.py:249 (Diff revision 1) > + proc = subprocess.Popen(*args, stdout=subprocess.PIPE, > + stderr=subprocess.STDOUT, **kwargs) > + while True: > + line = proc.stdout.readline() There /may/ be a buffering issue lingering in here somewhere on some platforms. But this is still better than it was before, so it isn't a big deal if there is. ::: build/subconfigure.py:255 (Diff revision 1) > + print prefix_lines(line.rstrip(), prefix) > + sys.stdout.flush() One thing I've started doing for scripts that will always be executed by other scripts and won't cause problems if buffering is enabled since stdout goes to a pipe is to unbuffer stdout. `sys.stdout = os.fdopen(sys.stdout.fileno(), 'w', 1)`. You typically do that in __main__ or the entry point to the script.
Attachment #8873752 - Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a784646bf7be Remove support for running subconfigures in parallel. r=gps https://hg.mozilla.org/integration/autoland/rev/372bdca82f66 Print out subconfigure output while it runs. r=gps
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: