Paul Adenot (:padenot) Assignee
	Description • 7 years ago

The wrong key was specified in dom.properties (missing "Warning" at the end) so this was not getting logged in the console.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8873803 [details]
Bug 1369698 - Fix the key for the URL.createObjectURL(MediaStream) deprecation string.

https://reviewboard.mozilla.org/r/145232/#review149176

	Paul Adenot (:padenot) Assignee
	Comment 3 • 7 years ago

Thanks to Belén for the good find and Sole for the heads up!

	Pulsebot
	Comment 4 • 7 years ago

Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/autoland/rev/1c58753cc0fa
Fix the key for the URL.createObjectURL(MediaStream) deprecation string. r=smaug

	Paul Adenot (:padenot) Assignee
	Comment 5 • 7 years ago

Comment on attachment 8873803 [details]
Bug 1369698 - Fix the key for the URL.createObjectURL(MediaStream) deprecation string.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1334564
[User impact if declined]: We're trying to deprecate an API, but the message that would inform the user of our intent wasn't working because of a typo.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes, manually.
[Needs manual test from QE? If yes, steps to reproduce]: Should be safe now, I verified manually, but opening https://mozdevs.github.io/MediaRecorder-examples/get-canvas-stream.html and verifying that a message is printed in the developer tools' console would be the steps.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No.
[Why is the change risky/not risky?]: This is not changing code, only a string identifier.
[String changes made/needed]: Not a string change, but a key change in `dom.properties`.

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/1c58753cc0fa

	Francesco Lodolo [:flod]
	Comment 7 • 7 years ago

(In reply to Paul Adenot (:padenot) from comment #5)
> [String changes made/needed]: Not a string change, but a key change in
> `dom.properties`.

That counts as a string change.

	Gerry Chang [:gchang]
	Comment 8 • 7 years ago

Comment on attachment 8873803 [details]
Bug 1369698 - Fix the key for the URL.createObjectURL(MediaStream) deprecation string.

Per comment #7, we won't allow string change in the beta cycle. Beta54-.