Closed
Bug 1369840
Opened 7 years ago
Closed 7 years ago
Support APZTestData APIs in WebRenderLayerManager
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(4 files)
The APZ mochitests use some APZTestData things that currently only exist in ClientLayerManager and PLayerTransaction. For these mochitests to work with APZ enabled we need these things implemented in WebRenderLayerManager and PWebRenderBridge as well.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8873949 [details] Bug 1369840 - Add new test IPDL message to sync-messages.ini. https://reviewboard.mozilla.org/r/145354/#review149306
Attachment #8873949 -
Flags: review?(dvander) → review+
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8873947 [details] Bug 1369840 - Modify CompositorBridgeParentBase::GetAPZTestData to take a layers id instead of a transaction parent. https://reviewboard.mozilla.org/r/145350/#review149318 ::: gfx/layers/ipc/CompositorBridgeParent.cpp:1341 (Diff revision 1) > void > -CompositorBridgeParent::GetAPZTestData(const LayerTransactionParent* aLayerTree, > +CompositorBridgeParent::GetAPZTestData(const uint64_t& aLayersId, > APZTestData* aOutData) > { > MonitorAutoLock lock(*sIndirectLayerTreesLock); > *aOutData = sIndirectLayerTrees[mRootLayerTreeID].mApzTestData; Should we assert aLayersId == mRootLayerTreeID?
Attachment #8873947 -
Flags: review?(botond) → review+
|
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8873948 [details] Bug 1369840 - Support getting the compositor-side APZ test data over PWebRenderBridge. https://reviewboard.mozilla.org/r/145352/#review149320
Attachment #8873948 -
Flags: review?(botond) → review+
|
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8873950 [details] Bug 1369840 - Support content-side APZ test data in WebRenderLayerManager. https://reviewboard.mozilla.org/r/145356/#review149338 ::: layout/base/nsLayoutUtils.cpp:8512 (Diff revision 1) > const std::string& aKey, > const std::string& aValue) > { > if (ClientLayerManager* mgr = aManager->AsClientLayerManager()) { > mgr->LogTestDataForCurrentPaint(aScrollId, aKey, aValue); > + } else if (WebRenderLayerManager* wrlm = aManager->AsWebRenderLayerManager()) { Should we instead move the function up to LayerManager and give it a no-op implementation for other LayerManager subclasses?
Attachment #8873950 -
Flags: review?(botond) → review+
|
Assignee | |
Comment 9•7 years ago
|
||
(In reply to Botond Ballo [:botond] from comment #6) > Should we assert aLayersId == mRootLayerTreeID? Sounds reasonable, I'll add that. (In reply to Botond Ballo [:botond] from comment #8) > Should we instead move the function up to LayerManager and give it a no-op > implementation for other LayerManager subclasses? I considered that but I think in the long term we're not sure yet if WebRenderLayerManager is going to stick around or if it's going to be removed. That is, the original webrender plan called for having layers as an intermediate step and then getting rid of them and plumbing display items directly into the webrender display list. I don't know if we'll ever get around to actually doing that, but if we do then we'd have to move it again, so I'd rather leave it as-is for now.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 14•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=381aa4bed2b94f18db8819ecd9f70f7d71e5722c
|
||
Comment 15•7 years ago
|
||
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3fccc08e0486 Modify CompositorBridgeParentBase::GetAPZTestData to take a layers id instead of a transaction parent. r=botond https://hg.mozilla.org/integration/autoland/rev/4fe99b113fff Support getting the compositor-side APZ test data over PWebRenderBridge. r=botond https://hg.mozilla.org/integration/autoland/rev/581ca67895db Add new test IPDL message to sync-messages.ini. r=dvander https://hg.mozilla.org/integration/autoland/rev/b7bcbc5c1b92 Support content-side APZ test data in WebRenderLayerManager. r=botond
|
|
||
Comment 16•7 years ago
|
||
Backed out for crashing in test_bug1151663.html on Android 4.3 api15+ debug: https://hg.mozilla.org/integration/autoland/rev/2ba8cf87141eb96731b220960c49edc9aa4f089b https://hg.mozilla.org/integration/autoland/rev/f2ccb2f276b24d6b4308bd084886262065dd4faf https://hg.mozilla.org/integration/autoland/rev/2618641a6d612208290422e8a04b49b247ad0eea https://hg.mozilla.org/integration/autoland/rev/ec5dcacaf5a9637a321fdc5afbee0ec21a40655e Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b7bcbc5c1b924d4c29813bbd3927ab1eb323b0bb&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=104243901&repo=autoland [task 2017-06-03T02:57:15.637815Z] 02:57:15 INFO - 139 INFO TEST-START | gfx/layers/apz/test/mochitest/test_bug1151663.html [task 2017-06-03T02:57:37.171342Z] 02:57:37 INFO - INFO | automation.py | Application ran for: 0:18:34.674966 [task 2017-06-03T02:57:37.171817Z] 02:57:37 INFO - INFO | zombiecheck | Reading PID log: /tmp/tmp4I4NStpidlog [task 2017-06-03T02:57:37.815045Z] 02:57:37 INFO - /data/tombstones does not exist; tombstone check skipped [task 2017-06-03T02:57:38.828204Z] 02:57:38 INFO - mozcrash Copy/paste: /home/worker/workspace/build/linux64-minidump_stackwalk /tmp/tmprYWFES/4db4e881-6360-87f4-0b82-8a3bf75b8756.dmp /home/worker/workspace/build/symbols [task 2017-06-03T02:57:47.122786Z] 02:57:47 INFO - mozcrash Saved minidump as /home/worker/workspace/build/blobber_upload_dir/4db4e881-6360-87f4-0b82-8a3bf75b8756.dmp [task 2017-06-03T02:57:47.123247Z] 02:57:47 INFO - mozcrash Saved app info as /home/worker/workspace/build/blobber_upload_dir/4db4e881-6360-87f4-0b82-8a3bf75b8756.extra [task 2017-06-03T02:57:47.126997Z] 02:57:47 WARNING - PROCESS-CRASH | gfx/layers/apz/test/mochitest/test_bug1151663.html | application crashed [@ mozilla::layers::CompositorBridgeParent::GetAPZTestData] [task 2017-06-03T02:57:47.127349Z] 02:57:47 INFO - Crash dump filename: /tmp/tmprYWFES/4db4e881-6360-87f4-0b82-8a3bf75b8756.dmp [task 2017-06-03T02:57:47.129851Z] 02:57:47 INFO - Operating system: Android [task 2017-06-03T02:57:47.129923Z] 02:57:47 INFO - 0.0.0 Linux 2.6.29-gea477bb #1 Wed Sep 26 11:04:45 PDT 2012 armv7l [task 2017-06-03T02:57:47.129952Z] 02:57:47 INFO - CPU: arm [task 2017-06-03T02:57:47.129986Z] 02:57:47 INFO - ARMv7 ARM Cortex-A8 features: swp,half,thumb,fastmult,vfpv2,edsp,neon,vfpv3 [task 2017-06-03T02:57:47.130005Z] 02:57:47 INFO - 1 CPU [task 2017-06-03T02:57:47.130022Z] 02:57:47 INFO - GPU: UNKNOWN [task 2017-06-03T02:57:47.130051Z] 02:57:47 INFO - Crash reason: SIGSEGV [task 2017-06-03T02:57:47.130080Z] 02:57:47 INFO - Crash address: 0x0 [task 2017-06-03T02:57:47.130102Z] 02:57:47 INFO - Process uptime: not available [task 2017-06-03T02:57:47.130129Z] 02:57:47 INFO - Thread 30 (crashed) [task 2017-06-03T02:57:47.130201Z] 02:57:47 INFO - 0 libxul.so!mozilla::layers::CompositorBridgeParent::GetAPZTestData [CompositorBridgeParent.cpp:b7bcbc5c1b92 : 1340 + 0x2] [task 2017-06-03T02:57:47.130260Z] 02:57:47 INFO - r0 = 0x00000092 r1 = 0x405b8d60 r2 = 0x405b8d60 r3 = 0x00000000 [task 2017-06-03T02:57:47.130306Z] 02:57:47 INFO - r4 = 0x5adfbe85 r5 = 0x55b7a318 r6 = 0x59280ba8 r7 = 0x00000000 [task 2017-06-03T02:57:47.130641Z] 02:57:47 INFO - r8 = 0x59280bb4 r9 = 0x59280b90 r10 = 0xffffffff r12 = 0x00000003 [task 2017-06-03T02:57:47.130787Z] 02:57:47 INFO - fp = 0x582f09c0 sp = 0x59280b38 lr = 0x5adeea2b pc = 0x5adfbeac [task 2017-06-03T02:57:47.131061Z] 02:57:47 INFO - Found by: given as instruction pointer in context [task 2017-06-03T02:57:47.131508Z] 02:57:47 INFO - 1 libxul.so!mozilla::layers::LayerTransactionParent::RecvGetAPZTestData [LayerTransactionParent.cpp:b7bcbc5c1b92 : 852 + 0x1] [task 2017-06-03T02:57:47.131641Z] 02:57:47 INFO - r4 = 0x5adfbe85 r5 = 0x59280c74 r6 = 0x00000000 r7 = 0x00000000 [task 2017-06-03T02:57:47.131895Z] 02:57:47 INFO - r8 = 0x59280bb4 r9 = 0x59280b90 r10 = 0xffffffff fp = 0x582f09c0 [task 2017-06-03T02:57:47.132166Z] 02:57:47 INFO - sp = 0x59280b50 pc = 0x5adee869 [task 2017-06-03T02:57:47.132419Z] 02:57:47 INFO - Found by: call frame info [task 2017-06-03T02:57:47.132796Z] 02:57:47 INFO - 2 libxul.so!mozilla::layers::PLayerTransactionParent::OnMessageReceived [PLayerTransactionParent.cpp:b7bcbc5c1b92 : 720 + 0xb] [task 2017-06-03T02:57:47.133152Z] 02:57:47 INFO - r4 = 0x55b8cd70 r5 = 0x59280c74 r6 = 0x59280ba8 r7 = 0x00000000 [task 2017-06-03T02:57:47.133505Z] 02:57:47 INFO - r8 = 0x59280bb4 r9 = 0x59280b90 r10 = 0xffffffff fp = 0x582f09c0 [task 2017-06-03T02:57:47.133828Z] 02:57:47 INFO - sp = 0x59280b68 pc = 0x5aa88ffb [task 2017-06-03T02:57:47.134142Z] 02:57:47 INFO - Found by: call frame info [task 2017-06-03T02:57:47.134510Z] 02:57:47 INFO - 3 libxul.so!mozilla::ipc::MessageChannel::DispatchSyncMessage [MessageChannel.cpp:b7bcbc5c1b92 : 2039 + 0x9] [task 2017-06-03T02:57:47.134879Z] 02:57:47 INFO - r4 = 0x54955ab0 r5 = 0x59280c74 r6 = 0x55b7a08c r7 = 0x59280c24 [task 2017-06-03T02:57:47.135247Z] 02:57:47 INFO - r8 = 0x59280c28 r9 = 0x59280c78 r10 = 0x59280c78 fp = 0x582f09c0 [task 2017-06-03T02:57:47.135544Z] 02:57:47 INFO - sp = 0x59280c18 pc = 0x5aa0fd9b [task 2017-06-03T02:57:47.135865Z] 02:57:47 INFO - Found by: call frame info [task 2017-06-03T02:57:47.136162Z] 02:57:47 INFO - 4 libxul.so!mozilla::ipc::MessageChannel::DispatchMessage [MessageChannel.cpp:b7bcbc5c1b92 : 1997 + 0x9] [task 2017-06-03T02:57:47.136373Z] 02:57:47 INFO - r4 = 0x54955ab0 r5 = 0x55b7a08c r6 = 0x59280c74 r7 = 0x59280c8c [task 2017-06-03T02:57:47.136727Z] 02:57:47 INFO - r8 = 0xffffffe1 r9 = 0x59280c78 r10 = 0x00000001 fp = 0x582f09c0 [task 2017-06-03T02:57:47.136846Z] 02:57:47 INFO - sp = 0x59280c68 pc = 0x5aa15f2b [task 2017-06-03T02:57:47.137097Z] 02:57:47 INFO - Found by: call frame info [task 2017-06-03T02:57:47.137440Z] 02:57:47 INFO - 5 libxul.so!mozilla::ipc::MessageChannel::RunMessage [MessageChannel.cpp:b7bcbc5c1b92 : 1870 + 0x7] [task 2017-06-03T02:57:47.137614Z] 02:57:47 INFO - r4 = 0x55b7a08c r5 = 0x54955ab0 r6 = 0x54955a98 r7 = 0x00000001 [task 2017-06-03T02:57:47.137912Z] 02:57:47 INFO - r8 = 0x59280d3c r9 = 0x54955ab4 r10 = 0x00000000 fp = 0x00000000 [task 2017-06-03T02:57:47.138225Z] 02:57:47 INFO - sp = 0x59280cd0 pc = 0x5aa16c89 [task 2017-06-03T02:57:47.138504Z] 02:57:47 INFO - Found by: call frame info [task 2017-06-03T02:57:47.138762Z] 02:57:47 INFO - 6 libxul.so!mozilla::ipc::MessageChannel::MessageTask::Run [MessageChannel.cpp:b7bcbc5c1b92 : 1903 + 0x7] [task 2017-06-03T02:57:47.139117Z] 02:57:47 INFO - r4 = 0x54955a80 r5 = 0x55b7a09c r6 = 0x00000000 r7 = 0x59280d10 [task 2017-06-03T02:57:47.139317Z] 02:57:47 INFO - r8 = 0x59280d3c r9 = 0x580f9b70 r10 = 0x00000000 fp = 0x00000000 [task 2017-06-03T02:57:47.139537Z] 02:57:47 INFO - sp = 0x59280cf8 pc = 0x5aa16d9f [task 2017-06-03T02:57:47.139813Z] 02:57:47 INFO - Found by: call frame info [task 2017-06-03T02:57:47.140106Z] 02:57:47 INFO - 7 libxul.so!MessageLoop::RunTask [message_loop.cc:b7bcbc5c1b92 : 361 + 0x5] [task 2017-06-03T02:57:47.140315Z] 02:57:47 INFO - r4 = 0x54955a80 r5 = 0x59280e24 r6 = 0x00000000 r7 = 0x59280d10 [task 2017-06-03T02:57:47.140617Z] 02:57:47 INFO - r8 = 0x59280d3c r9 = 0x580f9b70 r10 = 0x00000000 fp = 0x00000000 [task 2017-06-03T02:57:47.140880Z] 02:57:47 INFO - sp = 0x59280d10 pc = 0x5a9f2247 [task 2017-06-03T02:57:47.141126Z] 02:57:47 INFO - Found by: call frame info [task 2017-06-03T02:57:47.141353Z] 02:57:47 INFO - 8 libxul.so!MessageLoop::DeferOrRunPendingTask [message_loop.cc:b7bcbc5c1b92 : 369 + 0x5] [task 2017-06-03T02:57:47.141566Z] 02:57:47 INFO - r4 = 0x59280d3c r5 = 0x59280d50 r6 = 0x59280e24 r7 = 0xc0c0c0c1 [task 2017-06-03T02:57:47.141817Z] 02:57:47 INFO - r8 = 0x000000aa r9 = 0x580f9b70 r10 = 0x00000000 fp = 0x00000000 [task 2017-06-03T02:57:47.142059Z] 02:57:47 INFO - sp = 0x59280d38 pc = 0x5a9f42b5 [task 2017-06-03T02:57:47.142296Z] 02:57:47 INFO - Found by: call frame info [task 2017-06-03T02:57:47.142521Z] 02:57:47 INFO - 9 libxul.so!MessageLoop::DoWork [message_loop.cc:b7bcbc5c1b92 : 444 + 0x3] [task 2017-06-03T02:57:47.142731Z] 02:57:47 INFO - r4 = 0x59280e24 r5 = 0x59280d50 r6 = 0x59280e24 r7 = 0xc0c0c0c1 [task 2017-06-03T02:57:47.142989Z] 02:57:47 INFO - r8 = 0x000000aa r9 = 0x580f9b70 r10 = 0x00000000 fp = 0x00000000 [task 2017-06-03T02:57:47.143189Z] 02:57:47 INFO - sp = 0x59280d50 pc = 0x5a9f4347 [task 2017-06-03T02:57:47.143384Z] 02:57:47 INFO - Found by: call frame info [task 2017-06-03T02:57:47.143633Z] 02:57:47 INFO - 10 libxul.so!base::MessagePumpDefault::Run [message_pump_default.cc:b7bcbc5c1b92 : 36 + 0x7] [task 2017-06-03T02:57:47.143864Z] 02:57:47 INFO - r4 = 0x580f9b60 r5 = 0x59280d98 r6 = 0x59280e24 r7 = 0x59280da0 [task 2017-06-03T02:57:47.144078Z] 02:57:47 INFO - r8 = 0x5cfc50c6 r9 = 0x580f9b70 r10 = 0x00000000 fp = 0x00000000 [task 2017-06-03T02:57:47.144268Z] 02:57:47 INFO - sp = 0x59280d80 pc = 0x5a9ef2ed [task 2017-06-03T02:57:47.144466Z] 02:57:47 INFO - Found by: call frame info [task 2017-06-03T02:57:47.144710Z] 02:57:47 INFO - 11 libxul.so!MessageLoop::RunInternal [message_loop.cc:b7bcbc5c1b92 : 238 + 0x3] [task 2017-06-03T02:57:47.144930Z] 02:57:47 INFO - r4 = 0x59280e24 r5 = 0x59280e24 r6 = 0x00000000 r7 = 0x580f9af4 [task 2017-06-03T02:57:47.145145Z] 02:57:47 INFO - r8 = 0x580f9ae8 r9 = 0x59181000 r10 = 0x59280f00 fp = 0x2a3a69a0 [task 2017-06-03T02:57:47.145336Z] 02:57:47 INFO - sp = 0x59280de0 pc = 0x5a9eff69 [task 2017-06-03T02:57:47.145530Z] 02:57:47 INFO - Found by: call frame info [task 2017-06-03T02:57:47.145787Z] 02:57:47 INFO - 12 libxul.so!MessageLoop::Run [message_loop.cc:b7bcbc5c1b92 : 231 + 0x5] [task 2017-06-03T02:57:47.146021Z] 02:57:47 INFO - r4 = 0x59280e24 r5 = 0x59280e24 r6 = 0x00000000 r7 = 0x580f9af4 [task 2017-06-03T02:57:47.146231Z] 02:57:47 INFO - r8 = 0x580f9ae8 r9 = 0x59181000 r10 = 0x59280f00 fp = 0x2a3a69a0 [task 2017-06-03T02:57:47.146426Z] 02:57:47 INFO - sp = 0x59280df8 pc = 0x5a9eff83 [task 2017-06-03T02:57:47.146621Z] 02:57:47 INFO - Found by: call frame info [task 2017-06-03T02:57:47.146864Z] 02:57:47 INFO - 13 libxul.so!base::Thread::ThreadMain [thread.cc:b7bcbc5c1b92 : 180 + 0x5] [task 2017-06-03T02:57:47.147078Z] 02:57:47 INFO - r4 = 0x580f9ae0 r5 = 0x59280e24 r6 = 0x00000000 r7 = 0x580f9af4 [task 2017-06-03T02:57:47.147295Z] 02:57:47 INFO - r8 = 0x580f9ae8 r9 = 0x59181000 r10 = 0x59280f00 fp = 0x2a3a69a0 [task 2017-06-03T02:57:47.147485Z] 02:57:47 INFO - sp = 0x59280e10 pc = 0x5a9f6d4b [task 2017-06-03T02:57:47.147702Z] 02:57:47 INFO - Found by: call frame info [task 2017-06-03T02:57:47.147928Z] 02:57:47 INFO - 14 libxul.so!ThreadFunc [platform_thread_posix.cc:b7bcbc5c1b92 : 38 + 0x5] [task 2017-06-03T02:57:47.148144Z] 02:57:47 INFO - r4 = 0x59280f00 r5 = 0x2a3a69a0 r6 = 0x5a9f59f1 r7 = 0x580f9ae0 [task 2017-06-03T02:57:47.148355Z] 02:57:47 INFO - r8 = 0x580f9ae8 r9 = 0x59181000 r10 = 0x59280f00 fp = 0x2a3a69a0 [task 2017-06-03T02:57:47.148550Z] 02:57:47 INFO - sp = 0x59280ee0 pc = 0x5a9f59f9 [task 2017-06-03T02:57:47.148782Z] 02:57:47 INFO - Found by: call frame info [task 2017-06-03T02:57:47.148971Z] 02:57:47 INFO - 15 libc.so + 0xca5a [task 2017-06-03T02:57:47.149197Z] 02:57:47 INFO - r3 = 0x00000000 r4 = 0x59280f00 r5 = 0x2a3a69a0 r6 = 0x5a9f59f1 [task 2017-06-03T02:57:47.149407Z] 02:57:47 INFO - r7 = 0x580f9ae0 r8 = 0x580f9ae8 r9 = 0x59181000 r10 = 0x59280f00 [task 2017-06-03T02:57:47.149612Z] 02:57:47 INFO - fp = 0x2a3a69a0 sp = 0x59280ee8 pc = 0x40033a5c [task 2017-06-03T02:57:47.149832Z] 02:57:47 INFO - Found by: call frame info [task 2017-06-03T02:57:47.150061Z] 02:57:47 INFO - 16 libc.so + 0xcbd6 [task 2017-06-03T02:57:47.150300Z] 02:57:47 INFO - sp = 0x59280f00 pc = 0x40033bd8 [task 2017-06-03T02:57:47.150493Z] 02:57:47 INFO - Found by: stack scanning [task 2017-06-03T02:57:47.150692Z] 02:57:47 INFO - 17 libcamera_metadata.so + 0x1d5e [task 2017-06-03T02:57:47.150932Z] 02:57:47 INFO - sp = 0x59280f18 pc = 0x405b8d60 [task 2017-06-03T02:57:47.151206Z] 02:57:47 INFO - Found by: stack scanning Further down in the log, there is: > [task 2017-06-03T02:57:50.287381Z] 02:57:50 INFO - 06-02 19:57:32.563 F/MOZ_Assert( 801): Assertion failure: aLayersId == mRootLayerTreeID, at /home/worker/workspace/build/src/gfx/layers/ipc/CompositorBridgeParent.cpp:1340
Flags: needinfo?(bugmail)
|
|
Assignee | |
Comment 17•7 years ago
|
||
the layers id can be 0 on android. try push is green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b7970db40cc73442ac00f7adad7e40c22b468fd, will reland with that change.
Flags: needinfo?(bugmail)
|
|
||
Comment 18•7 years ago
|
||
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e63c270082b1 Modify CompositorBridgeParentBase::GetAPZTestData to take a layers id instead of a transaction parent. r=botond https://hg.mozilla.org/integration/mozilla-inbound/rev/ab761f7af56a Support getting the compositor-side APZ test data over PWebRenderBridge. r=botond https://hg.mozilla.org/integration/mozilla-inbound/rev/55f978f3de86 Add new test IPDL message to sync-messages.ini. r=dvander https://hg.mozilla.org/integration/mozilla-inbound/rev/35a1edcf4726 Support content-side APZ test data in WebRenderLayerManager. r=botond
|
||
Comment 19•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e63c270082b1 https://hg.mozilla.org/mozilla-central/rev/ab761f7af56a https://hg.mozilla.org/mozilla-central/rev/55f978f3de86 https://hg.mozilla.org/mozilla-central/rev/35a1edcf4726
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Comment 20•7 years ago
|
||
as a note there is a platform microbenchmark for stylo which regressed with this: == Change summary for alert #7127 (as of June 08 2017 20:29 UTC) == Regressions: 14% Stylo Gecko_nsCSSParser_ParseSheet_Bench windows8-64 opt 80,712.00 -> 91,873.17 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7127 I have cc'd :bholley and :SimonSapin on here who knows more about this test and can determine if this is something we need to fix.
|
||
Comment 21•7 years ago
|
||
Gecko_nsCSSParser_ParseSheet_Bench is the "old" non-Stylo parser that we’re comparing Servo_StyleSheet_FromUTF8Bytes_Bench against. As long as it’s the former and not the latter regressing…
|
||
Comment 22•7 years ago
|
||
Though, hm: I don't see the Servo_ one anywhere on the graphs. I would expect to see them on the linux64-stylo builds. Are we running platform_microbench there? Note that we're not running _anything_ as of yesterday, per bug 1371497.
Flags: needinfo?(jmaher)
|
|
||
Comment 23•7 years ago
|
||
The Servo_ on is inside #ifdef MOZ_STYLO, for what it’s worth.
|
|
||
Comment 24•7 years ago
|
||
this is a test which is run in the job titled: 'gtest'. I see this running for many builds, but not stylo: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=linu%20stylo&selectedJob=105689044 Should we look into getting the gtest job running on stylo? we have gtest defined here: https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/test/tests.yml#239 stylo is not in the 'built-projects' list, so we would need to add specific lines for stylo, as seen here: https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/test/tests.yml#1164 Do let us know if we should be running gtest on linux64-stylo (and maybe sequential?!?) builds and we can do that (or I can review a patch!)
Flags: needinfo?(jmaher)
|
|
||
Comment 25•7 years ago
|
||
(In reply to Joel Maher ( :jmaher) from comment #24) > this is a test which is run in the job titled: 'gtest'. I see this running > for many builds, but not stylo: > https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter- > searchStr=linu%20stylo&selectedJob=105689044 > > Should we look into getting the gtest job running on stylo? Hm. I'd certainly like the ability to track parser performance on perfherder for the linux64-stylo job, so if it's easy to turn on for linux64-stylo (ideally on mozilla-central only, like we do for the Talos test), I'd be in favor of that. That said, we're (hopefully) a week or two away for building stylo by default on most/all desktop platforms, at which point MOZ_STYLO will be defined, and the number should presumably show up automatically. So if it's not quick to do, we could also probably just wait for that.
|
|
||
Comment 26•7 years ago
|
||
I tried a few hacks in taskcluster and gtests were not scheduled, maybe it is best to wait for stylo to be on by default :)
|
|
||
Comment 27•7 years ago
|
||
(In reply to Joel Maher ( :jmaher) from comment #26) > I tried a few hacks in taskcluster and gtests were not scheduled, maybe it > is best to wait for stylo to be on by default :) That's fine. Thanks for trying!
|
|
Assignee | |
Comment 28•7 years ago
|
||
I'm assuming this means there's nothing I need to do about the reported microbenchmark regression in comment 20. I'm going to ignore it unless somebody says otherwise :)
|
|
||
Comment 29•7 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #28) > I'm assuming this means there's nothing I need to do about the reported > microbenchmark regression in comment 20. I'm going to ignore it unless > somebody says otherwise :) Yeah, unless it shows up on a non-microbenchmark-y test I wouldn't worry about it.
You need to log in
before you can comment on or make changes to this bug.
Description
•