Closed
Bug 1370133
Opened 7 years ago
Closed 7 years ago
Add workaround for _LIBCPP_ALWAYS_INLINE to support NDK r12+ with clang
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: m_kato, Assigned: froydnj)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
Bug 1277619 adds a workaround for visibility when using clang on NDK. When usign NDK r12+, it has _LIBCPP_ALWAYS_INLINE that has same problem.
_LIBCPP_ALWAYS_INLINE needs same workaround like _LIBCPP_INLINE_VISIBILITY
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → nfroyd
|
|
Assignee | |
Comment 1•7 years ago
|
||
_LIBCPP_ALWAYS_INLINE and its EXCEPT_GCC49 counterpart are broken in the
same fashion as _LIBCPP_INLINE_VISIBILITY and can be fixed in exactly
the same way.
Attachment #8883093 -
Flags: review?(cmanchester)
|
||
Updated•7 years ago
|
Attachment #8883093 -
Flags: review?(cmanchester) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/525cc3b789fc
add workarounds for _LIBCPP_ALWAYS_INLINE bustedness; r=chmanchester
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•