Closed Bug 1370192 Opened 7 years ago Closed 7 years ago

Remove DirectShowReader

Categories

(Core :: Audio/Video: Playback, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(2 files)

We no longer support Windows XP. DirectShowReader and relative can be removed.
Blocks: 1168435
Comment on attachment 8874425 [details] Bug 1370192: P1. Remove usage of DirectShowDecoder. https://reviewboard.mozilla.org/r/145800/#review149716 ::: dom/media/DecoderTraits.cpp:370 (Diff revision 1) > -#ifdef MOZ_DIRECTSHOW > - if (DirectShowDecoder::GetSupportedCodecs(aType, nullptr)) { > - decoderReader = new DirectShowReader(aDecoder); > - } else > -#endif > if (false) {} // dummy if to take care of the dangling else No longer necessary, either.
Attachment #8874425 - Flags: review?(cpearce) → review+
Comment on attachment 8874426 [details] Bug 1370192: P2. Remove DirectShow's reader and relative. https://reviewboard.mozilla.org/r/145802/#review149872 Our DirectShow support was one of the first large blocks of code I wrote at Mozilla, which was in the product, then out of the product, then in the product again. RIP DirectShowReader. ::: commit-message-a9da7:4 (Diff revision 2) > +Bug 1370192: P2. Remove DirectShow's reader and relative. r?cpearce > + > +MozReview-Commit-ID: ESYagjKpS5E > + There's also a comment in ThreadPoolCOMListener.h that mentions DirectShow, which can also be removed.
Attachment #8874426 - Flags: review?(cpearce) → review+
Pushed by jyavenard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b5ca49920b5 P1. Remove usage of DirectShowDecoder. r=cpearce https://hg.mozilla.org/integration/autoland/rev/037c44d17f4d P2. Remove DirectShow's reader and relative. r=cpearce
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: