Closed
Bug 1370215
Opened 7 years ago
Closed 7 years ago
Add the AsyncShutdownTimeout and ShutdownProgress to the crashreporter client crash ping assembly whitelist
Categories
(Toolkit :: Crash Reporting, enhancement)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: gsvelto, Assigned: gsvelto)
References
Details
Attachments
(1 file)
The AsyncShutdownTimeout [1] and ShutdownProgress [2] annotations are whitelisted for sending in the crash ping but they are missing from the whitelist included in the crashreporter client [3]. This bug is for adding them back.
This bug strengthens my resolve for fixing bug 1348273 and having only one list of annotations from which code is generate to prevent further issues like this one.
[1] https://dxr.mozilla.org/mozilla-central/rev/8a3aa1701537ea6b8334f432cd030d260d492fa3/toolkit/components/crashes/CrashManager.jsm#228
[2] https://dxr.mozilla.org/mozilla-central/rev/8a3aa1701537ea6b8334f432cd030d260d492fa3/toolkit/components/crashes/CrashManager.jsm#234
[3] https://dxr.mozilla.org/mozilla-central/rev/8a3aa1701537ea6b8334f432cd030d260d492fa3/toolkit/crashreporter/client/ping.cpp#124
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8874418 [details]
Bug 1370215 - Add the AsyncShutdownTimeout and ShutdownProgress annotations to the crash ping sent via the crashreporter client;
https://reviewboard.mozilla.org/r/145788/#review149770
Attachment #8874418 -
Flags: review?(ted) → review+
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01baa0629d25
Add the AsyncShutdownTimeout and ShutdownProgress annotations to the crash ping sent via the crashreporter client; r=ted
Comment 4•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•