The Page Setup dialogue should have an "Apply" button so that you can preview the changes you have made. At least when you launch Page Setup from within Print Preview. Maybe the "Apply" button shouldn't have to appear if you launch Page Setup from the Navigator window, because then there would be no need for it anyway. Or it could be dimmed (disabled).

agreed Also imho print preview should behave like PREFERENCES and BOOKMARK settings so you can scroll down after you click apply to check the changes you've made, without leaving PAGE SETUP (i guess it's called MODAL?). PS : reporter please change platform to ALL, because i'm also seeing this on my win2k and win xp pro machines

All/all.

Be careful with the use of 'Apply' buttons. Are they used elsewhere in Mozilla (where)? I think the real problem here is not that an Apply button is missing from the Page Setup dialog, but that it is difficult to change the page orientation from within the print preview.

See also bug 132017. I propose to dupe this one or make it dependent on 132017.

It might be diffcicult to change the orientation in PP when on Linux. but that is because the PP toolbar on Linux is missing some of functionality because of another bug. I have the Apply working and it is very useful, without it you sometimes have to print a page just to make certain changes "stick" before going into PP. Although the rest of Moz may not have an Apply I think the benefits here outweight the need to have an absolutely consistent UI.

Changing paper size in the Page Setup Dialog is completely unreleated to having an Apply button, though it might be one of the attrs that gets "commited" by the apply.

This patch implements the observers into the nsIPrintingPromptServices for being notified when page setup changes. This way The PrintSettings can be changed with an "Apply" button in the Page Setup Dialog. Also, PP must listen for these notification inorder to update PP and its UI when the Page Setup Dialog is being shown.

Comment on attachment 107143 [details] [diff] [review] patch v1 See comment above

Comment on attachment 107143 [details] [diff] [review] patch v1 "isEquals" is bad grammer - its either "equals" or "isEqual" but not both. and given that we're just comparing two values, do we really need to divide by 100 before comparing them?

Comment on attachment 107143 [details] [diff] [review] patch v1 ok, everything else looks good. sr=alecf with the equals/isEqual change, and not dividing by 100

Comment on attachment 107143 [details] [diff] [review] patch v1 r=sgehani

So what is going with this bug? In 1.6 there is still no Apply button, the last comment was "seems OK". If we don't include it in the main trunk, it will not see much testing...

4 year old patch with r+sr and noone has checked it in. It must have bitrotted by now ...