How to reproduce: Click on the padding area of an input[type=date] (highlighted blue in the attached image). What should happen: First subfield should be selected and date chooser should be opened, just like when clicking the empty part of the content box (highlighted red). What is happening: First subfield (month) is selected.

[triage] P2.

Hi Mike, could you take a look at this tiny patch? :)

Comment on attachment 8897693 [details] [diff] [review] patch, v1. Review of attachment 8897693 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! This looks good, but I have some minor questions - see below. -'ing until I hear back. ::: toolkit/content/widgets/datetimebox.xml @@ +1236,5 @@ > mozSystemGroup: true > }); > + // This is to open the picker when input element's padding area is > + // clicked. > + this.mInputElement.addEventListener("click", this, Should we be removing this (and the blur listener) in the destructor? Also, since we're listening to the "click" event here, can we safely remove "click" from EVENTS?

(In reply to Mike Conley (:mconley) from comment #3) > Comment on attachment 8897693 [details] [diff] [review] > patch, v1. > > Review of attachment 8897693 [details] [diff] [review]: > ----------------------------------------------------------------- > > Thanks! This looks good, but I have some minor questions - see below. > > -'ing until I hear back. > > ::: toolkit/content/widgets/datetimebox.xml > @@ +1236,5 @@ > > mozSystemGroup: true > > }); > > + // This is to open the picker when input element's padding area is > > + // clicked. > > + this.mInputElement.addEventListener("click", this, > > Should we be removing this (and the blur listener) in the destructor? Yes, how did I forget about them. :/ > > Also, since we're listening to the "click" event here, can we safely remove > "click" from EVENTS? Yes, we can, since the click event on the xul element eventually bubbles up to the input element. Thanks for the suggestion.

Addressed review comment 3.

Comment on attachment 8898593 [details] [diff] [review] patch, v2. Review of attachment 8898593 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fecc3b17395a Open picker when input element's padding area is clicked. r=mconley