Closed
Bug 1371201
Opened 7 years ago
Closed 7 years ago
The mozilla icon at top of about:home should be shown at left-top under RTL languages
Categories
(Firefox :: General, defect, P1)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: rexboy, Assigned: rexboy)
References
Details
(Whiteboard: [photon-onboarding])
Attachments
(1 file)
The Mozilla icon of about:home is shown on the top right corner no matter what the language type it is. We should show it on the top left corner for RTL languages, just like what we do for the gear icon in about:newtab at top of the page.
One of the reason that we must fix it is we show an icon button for opening new onboarding experiences on the opposite side. If we don't support RTL in the right way the two icon stack together.
It should be an trivial one-line css changes, but not sure if we got other works to do.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8875659 [details]
bug 1371201 - Show Mozilla icon at top of about:home at left-top under RTL direction.
https://reviewboard.mozilla.org/r/147078/#review151244
Attachment #8875659 -
Flags: review?(dao+bmo) → review+
|
|
||
Updated•7 years ago
|
Assignee: nobody → rexboy
|
Assignee | |
Comment 3•7 years ago
|
||
Thank you Dao!
Adding some tags for project tracking.
Blocks: 1354046
Whiteboard: [photon-onboarding]
|
||
Updated•7 years ago
|
Flags: qe-verify+
QA Contact: jwilliams
|
|
||
Updated•7 years ago
|
Target Milestone: --- → Firefox 56
|
|
||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a1a5084b3f88
Show Mozilla icon at top of about:home at left-top under RTL direction. r=dao
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
|
||
Comment 6•7 years ago
|
||
Operating System : Windows OS 64 bit
Browser : Firefox Nightly 55.0
Bug Verified and Fixed
Bug Verification day [20170621]
Flags: needinfo?(jwilliams)
|
||
Comment 7•7 years ago
|
||
Per comment 6 and my findings I will change the status of this bug to Verified Fixed.
Status: RESOLVED → VERIFIED
Flags: needinfo?(jwilliams)
You need to log in
before you can comment on or make changes to this bug.
Description
•