Closed
Bug 1371311
Opened 7 years ago
Closed 7 years ago
Toggling full-screen on Photon menu does not cause the Hamburger Menu to disappear on Windows operating systems
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | verified |
People
(Reporter: u554753, Assigned: Gijs)
References
Details
(Whiteboard: [photon-structure])
Attachments
(1 file)
Steps to Reproduce:
1. Set browser.photon.structure.enabled to true
2. Restart browser
3. Navigate to photon hamburger menu
4. Toggle full-screen using the photon menu
Expected Result:
The hamburger menu disappears.
Actual Result:
The hamburger menu stays once full-screen is toggled.
This is only reproducible on Windows operating systems. Not reproducible on Mac or Linux
|
||
Updated•7 years ago
|
Flags: qe-verify+
QA Contact: gwimberly
Whiteboard: [photon-structure] [triage]
|
|
||
Updated•7 years ago
|
Priority: -- → P2
Whiteboard: [photon-structure] [triage] → [photon-structure]
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
|
||
Updated•7 years ago
|
Iteration: --- → 56.1 - Jun 26
Priority: P2 → P1
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8877561 [details]
Bug 1371311 - make full screen button hide the panel when clicked,
https://reviewboard.mozilla.org/r/149042/#review153890
::: browser/components/customizableui/content/panelUI.inc.xul:578
(Diff revision 1)
> + closemenu="none"
> tooltip="dynamic-shortcut-tooltip"/>
> <toolbarbutton id="appMenu-zoomEnlarge-button"
> class="subviewbutton subviewbutton-iconic"
> command="cmd_fullZoomEnlarge"
> + closemenu="none"
Oooh! My bad! Thanks for the fix!
Attachment #8877561 -
Flags: review?(mdeboer) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5fe503c737b6
make full screen button hide the panel when clicked, r=mikedeboer
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
|
||
Comment 5•7 years ago
|
||
I have reproduced this Bug with Nightly 55.0a1 (2017-06-08) on Windows 10, 64 Bit!
The bug's fix is now verified on latest Nightly 56.0a1
Build ID : 20170616030207
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
[bugday-20170614]
Verified on Windows, Ubuntu, and Mac.
You need to log in
before you can comment on or make changes to this bug.
Description
•