Closed
Bug 1371492
Opened 7 years ago
Closed 7 years ago
Use AutoTArray to save current listener in NotifySelectionListeners
Categories
(Core :: DOM: Selection, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Actually, we use nsCOMArray for mSelectionListeners. NotifySelectionListeners saves current listeners to another nsCOMArray then use it for observing.
When I debug it, array length is mostly ~5, and nsCOMArray uses malloc according to profiler. So since array length is small, we should use AutoTArray instead.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8876008 [details]
Bug 1371492 - Use AutoTArray to save current listener in NotifySelectionListeners.
I'll defer to smaug on this one.
Attachment #8876008 -
Flags: review?(mats) → review?(bugs)
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8876008 [details]
Bug 1371492 - Use AutoTArray to save current listener in NotifySelectionListeners.
https://reviewboard.mozilla.org/r/147450/#review151862
Attachment #8876008 -
Flags: review?(bugs) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/11e9775fd375
Use AutoTArray to save current listener in NotifySelectionListeners. r=smaug
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•