Closed
Bug 1371610
Opened 7 years ago
Closed 7 years ago
Delay getting the search component service until the first StartSearch
Categories
(Toolkit :: Autocomplete, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: mak, Assigned: florian)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
(deleted),
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
We currently initialize the search component on setInput, that means basically when we attach the controller. That means we initialize the location bar search component when the location bar gets focus, for example.
That should not be necessary until the user starts searching. We could probably try to do that lazily from StartSearch by checking mSearches.Length().
Assignee | ||
Comment 1•7 years ago
|
||
Try looks reasonably green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef068e63b4329149ea5022efcb9a1009c0d7c827
Attachment #8949102 -
Flags: review?(mak77)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → florian
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•7 years ago
|
||
Comment on attachment 8949102 [details] [diff] [review]
Patch
Review of attachment 8949102 [details] [diff] [review]:
-----------------------------------------------------------------
It looks great. I checked that all the relevant properties are still initialized in a timely manner, I didn't identify any issues with that. Thanks!
Attachment #8949102 -
Flags: review?(mak77) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/789903045a39
Delay getting the search component service until the first StartSearch, r=mak.
Comment 4•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•