Closed
Bug 1371719
Opened 7 years ago
Closed 7 years ago
Don't create an MSG if it's not going to be used immediately
Categories
(Core :: Audio/Video: MediaStreamGraph, enhancement, P2)
Core
Audio/Video: MediaStreamGraph
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: padenot, Assigned: padenot)
References
Details
Attachments
(1 file)
When separating the MSGs per docgroup or document, `test_eme_stream_capture_blocked_case3.html` calls `MediaStreamGraph::GetInstance`, and then fails to create a stream because it's not allowed (because of, here, EME), and the MSG sits there doing nothing until the end of the process, and can't shut down because it's not progressed in its life cycle state machine.
This is a footgun, and we should try to make it impossible to create an MSG without a stream, but in the meantime, this does the trick.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8876192 [details]
Bug 1371719 - Don't create a MediaStreamGraph without doing anything with it.
https://reviewboard.mozilla.org/r/147634/#review152034
Attachment #8876192 -
Flags: review?(rjesup) → review+
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → padenot
Updated•7 years ago
|
Rank: 21
Priority: -- → P2
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c4d113ff7fb
Don't create a MediaStreamGraph without doing anything with it. r=jesup
Comment 4•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•