The set of files installed into the Embed directory by doing a make in mozilla/embedding/config does not seem to be sufficient to run the editor. Try running mfcembed from the Embed directory, and create a new editor-- the window comes up, but no text can be entered. Copying all of the files from the full 'bin' directory makes it work. I'm not sure exactly which files from the 'bin' directory make the difference.

->mjudge

'composer' seems to be the missing component. After copying composer.dll and composer.xpt into the components directory, it works.

Mike, let's get this into 1.0 so we have the embeddable editor stuff going properly, even if it doesn't have users (yet).

fix this asap. if its not fixed allready.

Once we completely remove editorshell (bug 121648), we will no longer need the Composer component, correct?

If an embedders wants HTML editing, they'll always needs the composer DLL.

I was running the embed smoketests on mfcembed this morning and decided to launch a New Editor Window. I got this crash (from talkback): Stack Signature MSVCRT.DLL + 0x328b (0x7800328b) 18cc1b59 Email Address twalker@netscape.com Product ID MozillaTrunk Build ID 2002101604 Trigger Time 2002-10-16 11:12:20 Platform Win32 Operating System Windows 98 4.10 build 67766446 Module MSVCRT.DLL URL visited User Comments crash opening new editor window in mfcembed Trigger Reason Access violation Source File Name Trigger Line No. Stack Trace MSVCRT.DLL + 0x328b (0x7800328b) CEditorFrame::MakeEditable [c:/builds/seamonkey/mozilla/embedding/tests/mfcembed/EditorFrm.cpp, line 259] CEditorFrame::InitEditor [c:/builds/seamonkey/mozilla/embedding/tests/mfcembed/EditorFrm.cpp, line 142] MFC42.DLL + 0x228d (0x5f40228d) MFC42.DLL + 0x21e6 (0x5f4021e6) MFC42.DLL + 0x291d (0x5f40291d) CBrowserFrame::OnCmdMsg [c:/builds/seamonkey/mozilla/embedding/tests/mfcembed/BrowserFrm.cpp, line 300] MFC42.DLL + 0x2ae5 (0x5f402ae5) MFC42.DLL + 0x2b46 (0x5f402b46) MFC42.DLL + 0x1aff (0x5f401aff) MFC42.DLL + 0x1a88 (0x5f401a88) MFC42.DLL + 0x1a10 (0x5f401a10) MFC42.DLL + 0x19cf (0x5f4019cf) KERNEL32.DLL + 0x363b (0xbff7363b) KERNEL32.DLL + 0x24407 (0xbff94407) CStartupPrefsPage::CStartupPrefsPage [c:/builds/seamonkey/mozilla/embedding/tests/mfcembed/Preferences.cpp, line 84] MFC42.DLL + 0x1587 (0x5f401587)

In my latest trunk build I'm not seeing a crash - i can successfully open the Editor window. But i cannot type anything in the Editor's client area.

Please test again after recent major revisions to editor embedding code.

test from 11-18 can open the editor window without crashing. But still cannot get focus to type in or use the editor.

see bug 177972 for "can't type in MfcEmbed editor". One is probably a dupe of the other.

reassigning to someone still working on editor

Comment on attachment 116772 [details] [diff] [review] fixup embedding filesets Chak--does this fix the windows problems in mfcembed?

Comment on attachment 116772 [details] [diff] [review] fixup embedding filesets r=chak Applied the changes to my Mozilla trunk and built an embedding distribution. I was able to successfully run MfcEmbed from the embedding dist. and open an Editor window in which i could properly type.

Comment on attachment 116772 [details] [diff] [review] fixup embedding filesets alecf or sfraser--sr=? thanks in advance!

Comment on attachment 116772 [details] [diff] [review] fixup embedding filesets hmm.. it was my understanding that basebrowser-* stuff was not supposed to include composer stuff. furthermore, I don't understand why you're adding back the pippki stuff that I swear we removed purposefully some time back.

cc'ing dougt - I also think that these files are used for the gre, which would be bad... I don't think the GRE is supposed to include this either.

Sorry, i missed the pippki part - since i only checked the Windows part. As Alecf points out pippki.* files are not needed.

why would composer be part of the "base" browser? maybe these config files aren't adequate to fulfill everybody’s requirement and definition of "base"...

how weird, I didn't touch that block with the pippki stuff; maybe some other patch I applied did or some cvs merge glitch? I'm removing that change from that file. I think we should add composer for these reasons: fix mfcembed regression allow embedders to get midas functionality allow ppembed, cocoaembed, etc. to work for editing

to me, base-browser != editing. I think that we need to rethink how these manifest files scale and overlay each other.

Comment on attachment 116772 [details] [diff] [review] fixup embedding filesets I'm sr-'ing this for now because I'm drowning in my review queue. (but feel free to check in the comment typo in CBrowserShell.cpp) basebrowser is really supposed to be the smallest set of possible components..I just don't feel like composer.dll belongs there.

has this landed?

-->alecf

.

marking this WONTFIX.. composer is not going into the basebrowser fileset.