Closed
Bug 1371838
Opened 7 years ago
Closed 7 years ago
Register WebRender threads with the Gecko profiler
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox56 | --- | unaffected |
firefox57 | --- | unaffected |
firefox58 | --- | fixed |
People
(Reporter: mstange, Assigned: jerry)
References
(Blocks 1 open bug)
Details
(Keywords: feature, Whiteboard: [wr-reserve] [gfx-noted])
Attachments
(6 files, 2 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
WebRender launches a few threads internally. We'd like to be able to profile them, so we need to call functions on thread creation + destruction in order to register + unregister them with the Gecko Profiler.
Reporter | ||
Comment 1•7 years ago
|
||
This works but needs lots of cleanup, and comments, and the rust parts should be rewritten by somebody who actually knows rust.
Reporter | ||
Comment 2•7 years ago
|
||
Peter, would you like to take this over and finish it?
Flags: needinfo?(howareyou322)
Updated•7 years ago
|
Comment 3•7 years ago
|
||
Sure, I can help on this.
Assignee: nobody → howareyou322
Flags: needinfo?(howareyou322)
Updated•7 years ago
|
Depends on: stage-wr-next
Updated•7 years ago
|
Blocks: stage-wr-next
No longer depends on: stage-wr-next
Updated•7 years ago
|
status-firefox56:
--- → unaffected
status-firefox57:
--- → unaffected
Reporter | ||
Comment 4•7 years ago
|
||
It doesn't seem to be capturing any WebRender:WorkerThreads. I haven't checked why that is.
Attachment #8876292 -
Attachment is obsolete: true
Comment 5•7 years ago
|
||
With attachment 8917973 [details] [diff] [review], I'm able to capture WebRender::Backend but not WebRender::WorkerThreads too. I will clean up the patches for landing first because we need this bug for performance profiling.
Comment 6•7 years ago
|
||
Any update on how this is going? It would be good to land sooner rather than later.
Flags: needinfo?(howareyou322)
Comment 7•7 years ago
|
||
I think we need to modify here to capture WebRender::WorkerThreads.
http://searchfox.org/mozilla-central/source/gfx/webrender_bindings/src/bindings.rs#597
Assignee | ||
Comment 8•7 years ago
|
||
I will take the remaining works.
Assignee: howareyou322 → hshih
Status: NEW → ASSIGNED
Flags: needinfo?(howareyou322)
Assignee | ||
Comment 9•7 years ago
|
||
The WR's pr:
https://github.com/servo/webrender/pull/2014
Assignee | ||
Comment 10•7 years ago
|
||
MozReview-Commit-ID: 2gVAmU2xomP
Attachment #8926323 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 11•7 years ago
|
||
MozReview-Commit-ID: BUyTq2vz3cO
Attachment #8926324 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 12•7 years ago
|
||
MozReview-Commit-ID: yyFwBr21F3
Attachment #8926325 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 13•7 years ago
|
||
MozReview-Commit-ID: 7YbQNzTNpmE
Attachment #8926326 -
Flags: review?(jmuizelaar)
Assignee | ||
Updated•7 years ago
|
Attachment #8926325 -
Attachment is obsolete: true
Attachment #8926325 -
Flags: review?(jmuizelaar)
Updated•7 years ago
|
Priority: P3 → P1
Whiteboard: [gfx-noted] → [wr-reserve] [gfx-noted]
Updated•7 years ago
|
Attachment #8926323 -
Flags: review?(jmuizelaar) → review+
Updated•7 years ago
|
Attachment #8926324 -
Flags: review?(jmuizelaar) → review+
Updated•7 years ago
|
Attachment #8926328 -
Flags: review?(jmuizelaar) → review+
Updated•7 years ago
|
Attachment #8926326 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 15•7 years ago
|
||
MozReview-Commit-ID: 5mIoBmz59SR
Assignee | ||
Comment 16•7 years ago
|
||
Comment 17•7 years ago
|
||
Pushed by hshih@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e69fae378b7
export the gecko profiler registering function to WR. r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6ad193d398e
register the WR thread pool's thread to gecko profiler. r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fe8d225b7ba
add a custom thread listener to WR. r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/d352680181fc
set the window_id as renderer_id to WR. r=jrmuizel
Comment 18•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8e69fae378b7
https://hg.mozilla.org/mozilla-central/rev/a6ad193d398e
https://hg.mozilla.org/mozilla-central/rev/3fe8d225b7ba
https://hg.mozilla.org/mozilla-central/rev/d352680181fc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•