Closed
Bug 1371844
Opened 7 years ago
Closed 7 years ago
Add explicit API to set Debugging.failTestsOnAutoClose
Categories
(Toolkit :: Storage, enhancement)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(1 file)
test_sqlite.js sets a property on the Debugging object on the global in Sqlite.jsm like this:
Cu.getGlobalForObject(Sqlite).Debugging.failTestsOnAutoClose = enabled;
With JSM global merging (bug 1186409), the Debugging object will be on a special per-JSM object, not the global, so this will not work. I feel like it is reasonable to add an API that is exported by Sqlite.jsm to set this property and use that instead.
|
Assignee | |
Comment 1•7 years ago
|
||
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8881272 [details]
Bug 1371844 - Add explicit API to set Debugging.failTestsOnAutoClose in Sqlite.jsm.
https://reviewboard.mozilla.org/r/152484/#review157744
SGTM, thank you
Attachment #8881272 -
Flags: review?(mak77) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8fe35fb8366
Add explicit API to set Debugging.failTestsOnAutoClose in Sqlite.jsm. r=mak
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•