Closed
Bug 1372058
Opened 7 years ago
Closed 7 years ago
stylo: Don't do a full walk over all the stylesheets to compute @viewport if it's disabled.
Categories
(Core :: CSS Parsing and Computation, enhancement, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Gecko doesn't support the @viewport rule. Servo does (to some extent).
Servo implements it as a huge walk up over the stylesheets before going through any of them. There's no need to do that work if we're just not parsing @viewport.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8876544 [details]
Bug 1372058: Don't try to compute @viewport unnecessarily.
https://reviewboard.mozilla.org/r/147870/#review152448
Attachment #8876544 -
Flags: review?(bobbyholley) → review+
|
|
||
Comment 3•7 years ago
|
||
Did this land?
Assignee: nobody → emilio+bugs
Flags: needinfo?(emilio+bugs)
Priority: -- → P1
|
Assignee | |
Comment 4•7 years ago
|
||
Yes
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(emilio+bugs)
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•7 years ago
|
||
Err, meant to paste https://github.com/servo/servo/pull/17279 in the above comment.
You need to log in
before you can comment on or make changes to this bug.
Description
•