(This is another example where having a Remove method on EntryPtr would save us a lookup. I think using LookupForAdd in these cases is still preferable to Get+Put since the Remove is very rare.)

(Filed bug 1372333 about adding a Remove() method.)

Comment on attachment 8876860 [details] [diff] [review] Use LookupForAdd instead of Get+Put to avoid unnecessary hashtable lookups Review of attachment 8876860 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/console/Console.cpp @@ +2195,5 @@ > > aCountLabel = string; > > + const bool maxCountersReached = mCounterRegistry.Count() >= MAX_PAGE_COUNTERS; > + auto entry = mCounterRegistry.LookupForAdd(aCountLabel); Ew. I think this could be avoided by making EntryPtr a little more powerful, even beyond adding a Remove() method.

Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/eb36d574ec6e Use LookupForAdd instead of Get+Put to avoid unnecessary hashtable lookups. r=froydnj