Mike Conley (:mconley) (:⚙️) Assignee
	Description • 7 years ago

ts_paint measures how long it takes to paint the first window. Often times, the most important information about what the bottlenecks are preventing that first paint can be found using the Gecko Profiler.

ts_paint tries to use the Talos profiling scripts, but it uses an older one from the pre-e10s days. When it attempts to dump the profile, it only ends up dumping the profile for the content process, which is mostly useless, since what's usually blocking the first paint of the window is in the parent process.

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8876888 [details]
Bug 1372361 - Use TalosContentProfiler.js for ts_paint so that --geckoProfile runs return useful results.

https://reviewboard.mozilla.org/r/148214/#review152578

thanks for the patch, I assume this won't change any numbers.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 3 • 7 years ago

(In reply to Joel Maher ( :jmaher) from comment #2)
> Comment on attachment 8876888 [details]
> Bug 1372361 - Use TalosContentProfiler.js for ts_paint so that
> --geckoProfile runs return useful results.
> 
> https://reviewboard.mozilla.org/r/148214/#review152578
> 
> thanks for the patch, I assume this won't change any numbers.

It shouldn't, no - all changes should occur after the thing that's being measured.

	Pulsebot
	Comment 4 • 7 years ago

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a72582716f3f
Use TalosContentProfiler.js for ts_paint so that --geckoProfile runs return useful results. r=jmaher

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a72582716f3f

	Kris Maglione [:kmag]
	Comment 6 • 7 years ago

This causes problems when I run it locally, since the MozAfterPaint listener is now removed only after a number of await calls, and winds up processing multiple events rather than just one.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 7 • 7 years ago

(In reply to Kris Maglione [:kmag] from comment #6)
> This causes problems when I run it locally, since the MozAfterPaint listener
> is now removed only after a number of await calls, and winds up processing
> multiple events rather than just one.

We don't actually use the MozAfterPaint event in order to get a time though - we're using nsIAppStartup.getStartupInfo(). Or am I missing something?

	Kris Maglione [:kmag]
	Comment 8 • 7 years ago

(In reply to Mike Conley (:mconley) from comment #7)
> We don't actually use the MozAfterPaint event in order to get a time though
> - we're using nsIAppStartup.getStartupInfo(). Or am I missing something?

I'm talking about here:

http://searchfox.org/mozilla-central/rev/714606a8145636d93b116943d3a65a6a49d2acf8/testing/talos/talos/startup_test/tspaint_test.html#15-20

where we use MozAfterPaint listeners to trigger the report output, and wind up outputting it twice.

	Kris Maglione [:kmag]
	Comment 10 • 7 years ago

Comment on attachment 8880098 [details]
Bug 1372361: Remove MozAfterPaint listener before calling await.

Sorry, copy/paste fail.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 11 • 7 years ago

Thanks for fixing bug 1375219!