Bug 1360282 is adding the ability to just toggle the sidebar. Before you had to select from a menu item before opening it, so you never hit the case where: Open bookmarks sidebar Open a bookmark in the sidebar (right click on a bookmark -> Properties -> "Load this bookmark in the sidebar" -> Save -> click on the boomark) Click the toolbar button to toggle the sidebar off Click the toolbar button to toggle the sidebar on Result: the title is empty

The easy fix here is to not `this.title = ""` in hide(), and I think this would actually be OK after Bug 1360282 since all entry points run through show(), which will reset the title if needed. But I split it out into this bug so we have a chance to discuss separately. We may want to think through the overall 'load a page in the sidebar' lifecycle as well, since I think that's why some of the persistence is needed (at least `document.persist("sidebar-title", "value");` isn't relevant except for viewWebPanelsSidebar which has no title. See https://bugzilla.mozilla.org/show_bug.cgi?id=1360282#c27 for more info

I actually wrote an alternative patch to store the title somewhere other than in the DOM, but it seems to make no difference and this is simpler, so there we go. :-)

Comment on attachment 8898249 [details] Bug 1372601 - fix title being gone when closing and reopening the sidebar with a webpage loaded, https://reviewboard.mozilla.org/r/169616/#review176064 This seems OK to me. We have other similar issues around hiding and re-showing like Bug 1391280, and I don't think this exact same approach will work there (since "sidebarcommand" is used as a proxy for "should the sidebar be opened?", while the title isn't used for that).

Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/9266e46fa0d9 fix title being gone when closing and reopening the sidebar with a webpage loaded, r=bgrins

(In reply to Brian Grinstead [:bgrins] from comment #0) > Bug 1360282 is adding the ability to just toggle the sidebar. Before you > had to select from a menu item before opening it, so you never hit the case > where: > > Open bookmarks sidebar > Open a bookmark in the sidebar (right click on a bookmark -> Properties -> > "Load this bookmark in the sidebar" -> Save -> click on the boomark) > Click the toolbar button to toggle the sidebar off > Click the toolbar button to toggle the sidebar on > > Result: the title is empty I am able to verify this on Windows and Ubuntu with these STR, but I can't seem to find a "Properties" menu on Mac OSX using these steps. Any suggestions/alternatives in order to get this to load in the Bookmarks window?

Scratch that. Figured it out. Verified on Windows, Mac, and Ubuntu.