Closed
Bug 1372912
Opened 7 years ago
Closed 7 years ago
Make layout/reftests/async-scrolling/bg-fixed-child-mask.html pass on linux64-qr with APZ enabled
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(4 files, 1 obsolete file)
With WR+APZ enabled, the layout/reftests/async-scrolling/bg-fixed-child-mask.html reftest fails. This bug is for the patches that make it pass, without regressing any "earlier" tests.
Assignee | ||
Comment 1•7 years ago
|
||
Try pushes with [1] and without [2] APZ enabled. These patches build on top of the patches in bug 1372603.
[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e132d25bf457b12b99da61fe55a9feb5411c864
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=580e12b2b102bb71b46ec021344725d360b6545a
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
Those look good. (The APZ-enabled push is expected to have failures, as long as bg-fixed-child-mask.html isn't among them).
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8877700 -
Flags: review?(mrobinson)
Attachment #8877701 -
Flags: review?(mrobinson)
Attachment #8877702 -
Flags: review?(mrobinson)
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8877698 [details]
Bug 1372912 - Extract a PushLayerClip helper method.
https://reviewboard.mozilla.org/r/149134/#review153598
Attachment #8877698 -
Flags: review?(jmuizelaar) → review+
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8877699 [details]
Bug 1372912 - Push clips for all the scroll metadata scrollclips.
https://reviewboard.mozilla.org/r/149136/#review153600
Attachment #8877699 -
Flags: review?(jmuizelaar) → review+
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8877700 [details]
Bug 1372912 - Make the clip id more strongly typed.
https://reviewboard.mozilla.org/r/149138/#review153602
Attachment #8877700 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 12•7 years ago
|
||
After some IRC discussion with Martin, he explained that the "branch" thing I'm doing is not necessary and that soon passing a non-scrolling clip to PushClipAndScrollInfo won't work. So I removed those bits and the test still passes. I feel like we might run into scenarios we can't handle, but maybe we never create the type of layer tree I'm imagining. I'm not sure. Anyway, we can deal with those scenarios if/when we run into them.
For now I removed part 4 (I could have removed part 3 as well but figured it wouldn't hurt to keep it) and simplified part 5.
Try pushes with and without APZ enabled:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9d69a1622096bd1958cc4d2731319a5b0188fac
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f67f70827f91098113bd67a544b153952f203828
Assignee | ||
Comment 13•7 years ago
|
||
Those try pushes look good. Patches incoming.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8877702 -
Attachment is obsolete: true
Attachment #8877702 -
Flags: review?(mrobinson)
Attachment #8877702 -
Flags: review?(jmuizelaar)
Comment 18•7 years ago
|
||
mozreview-review |
Comment on attachment 8877701 [details]
Bug 1372912 - Place the layer local clip in the right spot for fixed-pos layers.
https://reviewboard.mozilla.org/r/149140/#review153960
This seems good to me. Feel free to wait for jrmuizel's review if you would like someone more familiar with Gecko code to review this as well.
Attachment #8877701 -
Flags: review?(mrobinson) → review+
Comment 19•7 years ago
|
||
mozreview-review |
Comment on attachment 8877700 [details]
Bug 1372912 - Make the clip id more strongly typed.
https://reviewboard.mozilla.org/r/149138/#review153962
Attachment #8877700 -
Flags: review?(mrobinson) → review+
Assignee | ||
Updated•7 years ago
|
Attachment #8877701 -
Flags: review?(jmuizelaar)
Comment 20•7 years ago
|
||
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b883786cf01
Extract a PushLayerClip helper method. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/6f148794682a
Push clips for all the scroll metadata scrollclips. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/8176859f8b70
Make the clip id more strongly typed. r=jrmuizel,mrobinson
https://hg.mozilla.org/integration/autoland/rev/18c0e82c745f
Place the layer local clip in the right spot for fixed-pos layers. r=mrobinson
Comment 21•7 years ago
|
||
Backed out for bustage at ScrollingLayersHelper.h:19: class 'LayerClip' was previously declared as a struct:
https://hg.mozilla.org/integration/autoland/rev/53067b8193dc849e693f4fff553b7149dea93509
https://hg.mozilla.org/integration/autoland/rev/656f10819385a03675d066e5d0abaf351a33677f
https://hg.mozilla.org/integration/autoland/rev/00dbcf762ef556226b350cfe82d3656db300de35
https://hg.mozilla.org/integration/autoland/rev/9ee1932fe123b0ba818a95d4c610001b097e8a43
Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=18c0e82c745fe3b54b3ae07f83f013d3ef8cca35&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Build log: https://treeherder.mozilla.org/logviewer.html#?job_id=107449744&repo=autoland
13:52:04 INFO - Unified_cpp_gfx_layers10.cpp
13:52:04 INFO - c:\builds\moz2_slave\autoland-w32-00000000000000000\build\src\obj-firefox\dist\include\mozilla/layers/ScrollingLayersHelper.h(19): error C2220: warning treated as error - no 'object' file generated
13:52:04 INFO - c:\builds\moz2_slave\autoland-w32-00000000000000000\build\src\obj-firefox\dist\include\mozilla/layers/ScrollingLayersHelper.h(19): warning C4099: 'mozilla::layers::LayerClip': type name first seen using 'struct' now seen using 'class'
13:52:04 INFO - c:\builds\moz2_slave\autoland-w32-00000000000000000\build\src\gfx\layers\FrameMetrics.h(711): note: see declaration of 'mozilla::layers::LayerClip'
13:52:04 INFO - c:/builds/moz2_slave/autoland-w32-00000000000000000/build/src/config/rules.mk:1005: recipe for target 'Unified_cpp_gfx_layers10.obj' failed
13:52:04 INFO - mozmake.EXE[5]: *** [Unified_cpp_gfx_layers10.obj] Error 2
Flags: needinfo?(bugmail)
Assignee | ||
Comment 22•7 years ago
|
||
Sorry, silly error. My compiler (and try pushes) didn't catch it.
Flags: needinfo?(bugmail)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8877701 -
Flags: review?(jmuizelaar)
Comment 27•7 years ago
|
||
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/037a153bb989
Extract a PushLayerClip helper method. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/b65804983bc8
Push clips for all the scroll metadata scrollclips. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/39215a3e0a45
Make the clip id more strongly typed. r=jrmuizel,mrobinson
https://hg.mozilla.org/integration/autoland/rev/622f421e5815
Place the layer local clip in the right spot for fixed-pos layers. r=mrobinson
Comment 28•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/037a153bb989
https://hg.mozilla.org/mozilla-central/rev/b65804983bc8
https://hg.mozilla.org/mozilla-central/rev/39215a3e0a45
https://hg.mozilla.org/mozilla-central/rev/622f421e5815
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•