Closed Bug 1372933 Opened 7 years ago Closed 7 years ago

Intermittent dom/base/test/browser_timeout_throttling_with_audio_playback.js | Got the correct timeout (6604 -

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: bkelly)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:timing])

Attachments

(1 file)

Relax time checks in browser_timeout_throttling_with_audio_playback.js back to previous levels. r=ehsan
(deleted), patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review
I guess I made the time checking too restrictive.
Assignee: nobody → bkelly
Blocks: 1371664
Status: NEW → ASSIGNED
Ehsan, this patch relaxes the time checks in this test back to previous levels of flexibility. On our relatively slow automation we can still fire the timeout pretty late. The test just not verifies we don't timeout as the background throttling would trigger.
Attachment #8877647 - Flags: review?(ehsan)
Attachment #8877647 - Flags: review?(ehsan) → review+
I am happy to see a patch on here already!
Whiteboard: [stockwell needswork]
Pushed by bkelly@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/942b95795474 Relax time checks in browser_timeout_throttling_with_audio_playback.js back to previous levels. r=ehsan
Whiteboard: [stockwell needswork] → [stockwell fixed:timing]
https://hg.mozilla.org/mozilla-central/rev/942b95795474
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: