Closed
Bug 1373378
Opened 7 years ago
Closed 7 years ago
Make layout/reftests/async-scrolling/position-fixed-iframe-2.html pass on linux64-qr with APZ enabled
Categories
(Core :: Graphics: WebRender, defect, P3)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
With WR+APZ enabled, the layout/reftests/async-scrolling/position-fixed-iframe-2.html reftest fails. This bug is for the patches that make it pass, without regressing any "earlier" tests.
Assignee | ||
Comment 1•7 years ago
|
||
Problem here seems to be that the fixed-pos div inside the iframe gets fixed to the root scrollframe of the root content document, instead of the iframe's root scrollframe.
Assignee | ||
Comment 2•7 years ago
|
||
The reason this happens is that the scrolling container that the fixed item is fixed to is no longer on the stack when we encounter the fixed item. It has already been popped off by that point. We can improve wr::DisplayListBuilder::ParentScrollIdFor to fix this.
Assignee | ||
Comment 3•7 years ago
|
||
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8878641 [details]
Bug 1373378 - Do a better job tracking the ancestor scrollids in DisplayListBuilder.
https://reviewboard.mozilla.org/r/149936/#review155268
Attachment #8878641 -
Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0dbc79e5d74d
Do a better job tracking the ancestor scrollids in DisplayListBuilder. r=jrmuizel
Comment 7•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•