Closed
Bug 1373444
Opened 7 years ago
Closed 7 years ago
Intermittent /html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.html | Unable to locate window: 6442450945
Categories
(Testing :: web-platform-tests, defect)
Tracking
(firefox56 fixed, firefox57 fixed)
RESOLVED
FIXED
mozilla57
People
(Reporter: intermittent-bug-filer, Assigned: jgraham)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell unknown])
Attachments
(1 file, 1 obsolete file)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Updated•7 years ago
|
Whiteboard: [stockwell needswork]
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Depends on: marionette-window-tracking
Comment 13•7 years ago
|
||
No, I don't think that this bug is dependent on bug 1373444. If you have a look at any of the logs of failing tests you see a content crash of Firefox which is the reason why the window cannot be found. So it's just a race condition before Firefox get shutdown by the crash reporter. The crash itself is covered as bug 1387684.
Sadly this test failure should be the result of the race and only happens when switchToWindow is called after the content process crashed and before Firefox is shutdown. In most cases such a second failure for a test doesn't make sense to get starred.
My proposal is to wait until bug 1387684 has been fixed.
Updated•7 years ago
|
Whiteboard: [stockwell needswork] → [stockwell unknown]
Comment hidden (Intermittent Failures Robot) |
Comment 15•7 years ago
|
||
So the patch on bug 1387684 landed 5 days ago but didn't stop this failure from happening. Interestingly we do not have any more failures since August 25th. Also this is/was a MacOS only issue.
OS: Unspecified → Mac OS X
Hardware: Unspecified → All
Comment 16•7 years ago
|
||
So the failure is still happening as OF data shows. I find it very hard by just looking at the minimal log output to figure out where we even fail on the runner side. Why don't we print out any stack from Python code of the runner which will help us to investigate wpt failures?
Flags: needinfo?(james)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 19•7 years ago
|
||
The fundamental issue here is that we are throwing for errors during teardown that we simply shouldn't.
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(james)
Comment hidden (Intermittent Failures Robot) |
Comment 21•7 years ago
|
||
mozreview-review |
Comment on attachment 8903182 [details]
Bug 1373444 - Fix typo in wpt harness,
https://reviewboard.mozilla.org/r/174954/#review181340
Attachment #8903182 -
Flags: review?(mjzffr) → review+
Comment 22•7 years ago
|
||
mozreview-review |
Comment on attachment 8903183 [details]
Bug 1373444 - Look for NoSuchWindowException when waiting for manual browser close in wpt,
https://reviewboard.mozilla.org/r/174956/#review181342
::: commit-message-6007d:4
(Diff revision 1)
> +Bug 1373444 - Look for NoSuchWindowException when waiting for manual browser close in wpt, r=maja_zf
> +
> +This method works by running a long-running script and catching the exception when
> +it is interrupted. But the exception changed so we much make a corresponding change here.
s/much/must/
Attachment #8903183 -
Flags: review?(mjzffr) → review+
Comment 23•7 years ago
|
||
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/00f0c5109767
Ignore exceptions during wpt test teardown, r=maja_zf
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec49322e332f
Look for NoSuchWindowException when waiting for manual browser close in wpt, r=maja_zf
Comment 24•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/00f0c5109767
https://hg.mozilla.org/mozilla-central/rev/ec49322e332f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•7 years ago
|
status-firefox56:
--- → affected
Updated•7 years ago
|
Assignee: nobody → james
Comment 25•7 years ago
|
||
bugherder uplift |
Comment 26•7 years ago
|
||
mozreview-review |
Comment on attachment 8903182 [details]
Bug 1373444 - Fix typo in wpt harness,
https://reviewboard.mozilla.org/r/174954/#review182000
::: testing/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py:518
(Diff revision 1)
> - handle = self.protocol.marionette.window_handles[0]
> + handle = self.protocol.marionette.window_handles[0]
> - self.protocol.marionette.switch_to_window(handle)
> + self.protocol.marionette.switch_to_window(handle)
> - super(self.__class__, self).teardown()
> + super(self.__class__, self).teardown()
> + except Exception as e:
> + # Ignore errors during teardown
> + self.logger.warning(traceback.traceback.format_exc(e))
I think you might have an extra `traceback.` here.
Attachment #8903182 -
Flags: review+
See previous comment -- I just noticed something broken.
Flags: needinfo?(james)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8903183 -
Attachment is obsolete: true
Comment 29•7 years ago
|
||
mozreview-review |
Comment on attachment 8903182 [details]
Bug 1373444 - Fix typo in wpt harness,
https://reviewboard.mozilla.org/r/174954/#review182572
Attachment #8903182 -
Flags: review?(mjzffr) → review+
Flags: needinfo?(james)
Comment 30•7 years ago
|
||
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/28c89bcb7b70
Fix typo in wpt harness, r=maja_zf
Comment 31•7 years ago
|
||
bugherder uplift |
Comment 32•7 years ago
|
||
bugherder |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•