Comment on attachment 8878605 [details] [diff] [review] Make editor mochitests correctly wait for spell checking to finish Review of attachment 8878605 [details] [diff] [review]: ----------------------------------------------------------------- ::: editor/libeditor/tests/test_bug432225.html @@ +60,5 @@ > getEdit().focus(); > sendString('aa OK '); > gMisspeltWords.push("aa"); > + SpecialPowers.Cu.import( > + "resource://testing-common/AsyncSpellCheckTestHelper.jsm", window); nit: It would be nicer if we did something more like the following, in order to avoid importing junk into the global scope, here and in the other tests: let {onSpellCheck} = SpecialPowers.Cu.import("resource://testing-common/AsyncSpellCheckTestHelper.jsm", {});

Sure, will do, but see <https://searchfox.org/mozilla-central/rev/20d16dadd336e0c6b97e3e19dc4ff907744b5734/editor/AsyncSpellCheckTestHelper.jsm#5>. :-)

Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f0bdf9af0636 Make editor mochitests correctly wait for spell checking to finish; r=mystor