Closed Bug 1373789 Opened 7 years ago Closed 7 years ago

Handle some types of malformed lines better

Categories

(Testing :: Code Coverage, defect)

Product:
Testing
Component:
Code Coverage
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox56 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file)

Patch
(deleted), patch
chmanchester
: review+
Details | Diff | Splinter Review
A line such as "FN:95,cubic-bezier(0.0, 0.0, 1.0, 1.0)" throws an error like this: > Traceback (most recent call last): > File "python/mozbuild/mozbuild/codecoverage/lcov_rewriter.py", line 687, in <module> > main() > File "python/mozbuild/mozbuild/codecoverage/lcov_rewriter.py", line 684, in main > rewriter.rewrite_file(f, args.output_suffix)\n File "python/mozbuild/mozbuild/codecoverage/lcov_rewriter.py", line 609, in rewrite_file > lcov_file = LcovFile(fh) > File "python/mozbuild/mozbuild/codecoverage/lcov_rewriter.py", line 238, in __init__ > self.parse_file(lcov_fh) > File "python/mozbuild/mozbuild/codecoverage/lcov_rewriter.py", line 287, in parse_file > LcovFile.__dict__[\'parse_\' + prefix](self, *args) > TypeError: parse_FN() takes exactly 3 arguments (6 given) with no information about the line itself nor the file that contained it.
Attached patch Patch (deleted) — — Splinter Review
With this patch applied, the error message is: > Invalid lcov line start at /home/marco/Documenti/FD/mozilla-unified/prova/1497630523-2591-0.info:563042: > FN:95,cubic-bezier(0.0, 0.0, 1.0, 1.0) > Traceback (most recent call last): > File "python/mozbuild/mozbuild/codecoverage/lcov_rewriter.py", line 691, in <module> > main() > File "python/mozbuild/mozbuild/codecoverage/lcov_rewriter.py", line 688, in main > rewriter.rewrite_file(f, args.output_suffix) > File "python/mozbuild/mozbuild/codecoverage/lcov_rewriter.py", line 613, in rewrite_file > lcov_file = LcovFile(fh) > File "python/mozbuild/mozbuild/codecoverage/lcov_rewriter.py", line 238, in __init__ > self.parse_file(lcov_fh) > File "python/mozbuild/mozbuild/codecoverage/lcov_rewriter.py", line 287, in parse_file > LcovFile.__dict__['parse_' + prefix](self, *args) > TypeError: parse_FN() takes exactly 3 arguments (6 given)
Attachment #8878642 - Flags: review?(cmanchester)
Comment on attachment 8878642 [details] [diff] [review] Patch Review of attachment 8878642 [details] [diff] [review]: ----------------------------------------------------------------- Thank you for the patch
Attachment #8878642 - Flags: review?(cmanchester) → review+
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/aa6b6b627a54 Handle some kinds of malformed lcov lines better. r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/aa6b6b627a54
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: