Closed
Bug 1373794
Opened 7 years ago
Closed 7 years ago
JSVM code coverage generates invalid FN records with function names containing commas
Categories
(Core :: JavaScript Engine, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
For example, "FN:95,cubic-bezier(0.0, 0.0, 1.0, 1.0)" from source file "http://mochi.test:8888/tests/layout/style/test/test_transitions.html".
Not sure what we should do here. Should we allow this and modify the LCOV parsing scripts accordingly?
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8878702 -
Flags: review?(cmanchester)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8878702 [details] [diff] [review]
Patch
Review of attachment 8878702 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. Let's add something to our test input at python/mozbuild/mozbuild/test/codecoverage/sample_lcov.info that triggers this as well.
Attachment #8878702 -
Flags: review?(cmanchester) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
I've added an explicit test in test_lcov_rewrite.py.
Attachment #8878722 -
Flags: review?(cmanchester)
|
|
||
Updated•7 years ago
|
Attachment #8878722 -
Flags: review?(cmanchester) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76ba64f4ee9c
Don't fail when FN or FNDA records contain function names with commas. r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e09847ffa58
Test parsing LCOV containing a function name with commas. r=chmanchester
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/76ba64f4ee9c
https://hg.mozilla.org/mozilla-central/rev/4e09847ffa58
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•