Closed
Bug 1373921
Opened 7 years ago
Closed 7 years ago
Remove duplicated css code from about:support/profiles/url-classifier
Categories
(Firefox :: Theme, enhancement, P5)
Tracking
()
RESOLVED
FIXED
Firefox 61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: urbankrajnc92, Assigned: urbankrajnc92)
References
Details
Attachments
(1 file, 2 obsolete files)
Screenshot with patch
No description provided.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 6•7 years ago
|
||
I suppose we'd take a patch, but I'd also support simply removing about:plugins now that NPAPI plugins are deprecated.
Priority: -- → P5
|
||
Comment 7•7 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #6) > I suppose we'd take a patch, TBH I don't think it's worth the effort / review time. UK92, would you mind preparing a patch for just about:support/profiles/url-classifier, leaving about:plugins alone?
Flags: needinfo?(urbankrajnc92)
|
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8878770 [details] Bug 1373921 - Remove duplicated css code from about:support/profiles/url-classifier https://reviewboard.mozilla.org/r/150076/#review198090
Attachment #8878770 -
Flags: review?(dao+bmo)
|
|
||
Comment 9•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8878771 [details] Bug 1373921 - Remove duplicated css code from about:support/profiles/url-classifier https://reviewboard.mozilla.org/r/150078/#review198092 ::: toolkit/content/aboutSupport.xhtml:30 (Diff revision 2) > src="chrome://global/content/aboutSupport.js"/> > <script type="application/javascript" > src="chrome://global/content/resetProfile.js"/> > </head> > > - <body dir="&locale.dir;"> > + <body dir="&locale.dir;" class="block"> I'm not a fan of this -- "block" is a nonsensical class name. That's not even any better than using style="display: block".
Attachment #8878771 -
Flags: review?(dao+bmo)
| Comment hidden (mozreview-request) |
Attachment #8878771 -
Attachment is obsolete: true
Flags: needinfo?(urbankrajnc92)
Summary: Update about:plugins to new in-content style → Remove duplicated css code from about:support/profiles/url-classifier
Attachment #8878772 -
Attachment is obsolete: true
| Comment hidden (mozreview-request) |
|
|
||
Comment 12•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8878770 [details] Bug 1373921 - Remove duplicated css code from about:support/profiles/url-classifier https://reviewboard.mozilla.org/r/150076/#review198568 ::: toolkit/content/aboutSupport.xhtml:30 (Diff revision 4) > src="chrome://global/content/aboutSupport.js"/> > <script type="application/javascript" > src="chrome://global/content/resetProfile.js"/> > </head> > > - <body dir="&locale.dir;"> > + <body dir="&locale.dir;" style="display: block"> How about adding a meaningfully descriptive class for this?
Attachment #8878770 -
Flags: review?(dao+bmo)
| Comment hidden (mozreview-request) |
|
|
||
Comment 14•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8878770 [details] Bug 1373921 - Remove duplicated css code from about:support/profiles/url-classifier https://reviewboard.mozilla.org/r/150076/#review198720 Thanks!
Attachment #8878770 -
Flags: review?(dao+bmo) → review+
|
||
Comment 15•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 25d64ac547bfbbf737f80d1e11fc6aa72ebed76d -d 2cd639e2998f: rebasing 455736:25d64ac547bf "Bug 1373921 - Remove duplicated css code from about:support/profiles/url-classifier r=dao" (tip) merging toolkit/content/aboutSupport.xhtml merging toolkit/content/aboutUrlClassifier.xhtml merging toolkit/themes/shared/in-content/common.inc.css warning: conflicts while merging toolkit/content/aboutUrlClassifier.xhtml! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
|
||
Comment 16•7 years ago
|
||
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dd609e3b9e0b Remove duplicated css code from about:support/profiles/url-classifier. r=dao
|
||
Comment 17•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dd609e3b9e0b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
|
||
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•